Skip to content

Do not use HITLDetailResponse from core in sdk #54358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 4 commits into from
Aug 18, 2025
Merged

Do not use HITLDetailResponse from core in sdk #54358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e929ebd
Do not use HITLDetailResponse from core in sdk
amoghrajesh Aug 11, 2025
6a97a90
static check fix
amoghrajesh Aug 12, 2025
8f768ea
Merge branch 'main' into use-correct-type-checking-hitl
amoghrajesh Aug 14, 2025
e7dd13e
Merge branch 'main' into use-correct-type-checking-hitl
amoghrajesh Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/standard/src/airflow/providers/standard/triggers/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
yield TriggerEvent(
HITLTriggerEventSuccessPayload(
chosen_options=resp.chosen_options,
params_input=resp.params_input,
params_input=resp.params_input or {},
Comment thread
amoghrajesh marked this conversation as resolved.
timedout=False,
)
)
Expand Down
2 changes: 1 addition & 1 deletion task-sdk/src/airflow/sdk/execution_time/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
)

if TYPE_CHECKING:
from airflow.api_fastapi.execution_api.datamodels.hitl import HITLDetailResponse
from airflow.sdk.api.datamodels._generated import HITLDetailResponse


def upsert_hitl_detail(
Expand Down
Loading