Merged
Conversation
…endent on the GitSync version
ido177
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
ido177
force-pushed
the
chart-gitsync-vars
branch
from
2dd6e18 to
d67907b
Compare
ido177
force-pushed
the
chart-gitsync-vars
branch
from
d67907b to
78d95d8
Compare
romsharon98
approved these changes
Oct 3, 2025
Contributor
romsharon98
left a comment
romsharon98
left a comment
There was a problem hiding this comment.
LGTM, there are more duplicate envs above your changes it will be nice to do the same for them
sc250072
pushed a commit
to Teradata/airflow
that referenced
this pull request
Oct 3, 2025
* make the variable name in .Values.dags.gitSync.credentials secret dependent on the GitSync version * update gitsync tests
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* make the variable name in .Values.dags.gitSync.credentials secret dependent on the GitSync version * update gitsync tests
potiuk
added a commit
that referenced
this pull request
Oct 13, 2025
* Error message improvied * Error messages of bteq improved * Bump ruff to 0.13.3 and prek to 0.2.3 (#56355) * fix: allow mapped tasks to accept zero-length inputs on rerun (#56162) * fix: allow mapped tasks to accept zero-length inputs on rerun * fix: add test for rerun args of different length * chore: revise comments to align with the changes * chore: add comments before the task state check * fix: replace legacy query syntax * Chart gitsync vars (#56245) * make the variable name in .Values.dags.gitSync.credentials secret dependent on the GitSync version * update gitsync tests * Update provider's metadata (#56357) * Fix install_java.sh (#56211) Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com> * Add new PL translations. (#56359) --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Zhen-Lun (Kevin) Hong <zhenlun.hong01@gmail.com> Co-authored-by: Kirill Romanikhin <63454209+ido177@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: VladaZakharova <uladaz@google.com> Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com>
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* Error message improvied * Error messages of bteq improved * Bump ruff to 0.13.3 and prek to 0.2.3 (apache#56355) * fix: allow mapped tasks to accept zero-length inputs on rerun (apache#56162) * fix: allow mapped tasks to accept zero-length inputs on rerun * fix: add test for rerun args of different length * chore: revise comments to align with the changes * chore: add comments before the task state check * fix: replace legacy query syntax * Chart gitsync vars (apache#56245) * make the variable name in .Values.dags.gitSync.credentials secret dependent on the GitSync version * update gitsync tests * Update provider's metadata (apache#56357) * Fix install_java.sh (apache#56211) Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com> * Add new PL translations. (apache#56359) --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Zhen-Lun (Kevin) Hong <zhenlun.hong01@gmail.com> Co-authored-by: Kirill Romanikhin <63454209+ido177@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: VladaZakharova <uladaz@google.com> Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com>
2 tasks
1 task
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 26, 2026
This reverts commit d0da0c0.
1 task
jedcunningham
added a commit
that referenced
this pull request
Jan 26, 2026
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
jason810496
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Feb 3, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
Ankurdeewan
pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
This reverts commit d0da0c0. Reverts apache#56245, as we can't safely use the tag to determine the version. Since we will be dropping support for 3 in the next release anyways, we will just keep it as-is for 1 more release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #56143
At this moment, users have to specify git_username and git_token twice in the git-sync secret, once for GIT_SYNC_* (v3) and once for GITSYNC_* (v4). This is redundant and confusing.
This PR updates the Helm chart logic to choose the correct environment variable set based on the git-sync image tag:
If the tag is < 4.0.0 - use GIT_SYNC_*
If the tag is >= 4.0.0 or latest - use GITSYNC_*
Example (after this change)
Only the relevant variables need to be set, depending on the git-sync version.