[v3-1-test] Fix systemd service files issues (#57126)#57231
Merged
Conversation
This commit addresses multiple bugs in systemd service files reported in issue #53706: 1. Fix incorrect command in airflow-api.service - Changed 'airflow api' to 'airflow api-server' (correct CLI command) 2. Standardize environment configuration approach - Changed airflow-api.service and airflow-triggerer.service to use EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment - This provides consistency with other services and allows admins flexibility to manage custom environment variables centrally 3. Fix service dependencies - Added proper After= and Wants= clauses for database and message queue services (postgresql, mysql, redis, rabbitmq) to airflow-api.service and airflow-triggerer.service - Services now wait for required dependencies before starting 4. Additional bug fixes discovered during review - airflow-flower.service: Removed duplicate ExecStart line - airflow-kerberos.service: Fixed command from 'kerberos' to 'airflow kerberos' 5. Consistency improvements - Added Type=simple and RestartSec=5s to airflow-api.service and airflow-triggerer.service for consistency with other services All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup. Fixes #53706 (cherry picked from commit b370160) Co-authored-by: Ashir Alam <alamashir@gmail.com>
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses multiple bugs in systemd service files reported
in issue #53706:
Fix incorrect command in airflow-api.service
Standardize environment configuration approach
EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
flexibility to manage custom environment variables centrally
Fix service dependencies
queue services (postgresql, mysql, redis, rabbitmq) to
airflow-api.service and airflow-triggerer.service
Additional bug fixes discovered during review
'airflow kerberos'
Consistency improvements
airflow-triggerer.service for consistency with other services
All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.
Fixes #53706
(cherry picked from commit b370160)
Co-authored-by: Ashir Alam alamashir@gmail.com