Skip to content

Repair k8 async connection getter#61138

Merged
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:onikolas/fix_kubernetes_async_conn
Jan 27, 2026
Merged

Repair k8 async connection getter#61138
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:onikolas/fix_kubernetes_async_conn

Conversation

@o-nikolas
Copy link
Copy Markdown
Contributor

@o-nikolas o-nikolas commented Jan 27, 2026 •
edited
Loading

in #56791 async connection generation was moved to a common module which uses the BaseHook's implementation of get_connection which will obviously not include any implementation that the child classes have in their get_connection methods. The kubernetes hook has some special handling in it's get_connection method. This handling is added one layer higher so that it is still present in the new call path.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@o-nikolas
Repair k8 async connection getter
5ca2d2c 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jan 27, 2026
@o-nikolas
Copy link
Copy Markdown
Contributor Author

o-nikolas commented Jan 27, 2026

CC @ramitkataria

vincbeck
vincbeck approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ramitkataria
ramitkataria approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ramitkataria ramitkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we add a unit test? Otherwise looks good to me

@vincbeck vincbeck merged commit 1f0c2c1 into apache:main Jan 27, 2026
104 checks passed
@vincbeck vincbeck deleted the onikolas/fix_kubernetes_async_conn branch January 27, 2026 20:10
@vincbeck vincbeck mentioned this pull request Jan 28, 2026
Closed
85 tasks
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@o-nikolas @shreyas-dev
Repair k8 async connection getter (apache#61138)
0c24ede 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
@o-nikolas @jason810496
Repair k8 async connection getter (apache#61138)
3de7d41 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@o-nikolas @jhgoebbert
Repair k8 async connection getter (apache#61138)
0b057e1 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@o-nikolas @choo121600
Repair k8 async connection getter (apache#61138)
6df1952 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@o-nikolas @Subham-KRLX
Repair k8 async connection getter (apache#61138)
ab50f1b 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@o-nikolas @Ankurdeewan
Repair k8 async connection getter (apache#61138)
8382e0a 
async connection generation was moved to a common module which uses
the BaseHook's implementation of get_connection which will obviously
not include any implementation that the child classes have in their
get_connection methods. The kubernetes hook has some special handling
in it's get_connection method. This handling is added one layer higher
so that it is still present in the new call path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferruzzi ferruzzi ferruzzi approved these changes

@vincbeck vincbeck vincbeck approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

+1 more reviewer

@ramitkataria ramitkataria ramitkataria approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@o-nikolas @ferruzzi @ramitkataria @vincbeck