Skip to content

Remove Keycloak access token from cookie to not exceed cookie size limit #61773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
exolightor wants to merge 3 commits into from
Closed

Remove Keycloak access token from cookie to not exceed cookie size limit #61773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00949c8
remove Keycloak access token from cookie to not exceed cookie size li…
exolightor Feb 11, 2026
c6ba658
adjust tests to accommodate for empty Keycloak access token (#61771)
exolightor Feb 12, 2026
253c5fd
trigger refresh token flow in case access token is missing in cookie …
exolightor Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def refresh_user(self, *, user: KeycloakAuthManagerUser) -> KeycloakAuthManagerU
if not user.refresh_token:
return None

if self._token_expired(user.access_token):
if not user.access_token or self._token_expired(user.access_token):
tokens = self.refresh_tokens(user=user)

if tokens:
Expand Down Expand Up @@ -368,6 +368,9 @@ def _is_authorized(
elif method == "GET":
method = "LIST"

# in case access token is expired or missing
self.refresh_user(user=user)

resp = self.http_session.post(
self._get_token_url(server_url, realm),
data=self._get_payload(client_id, f"{resource_type.value}#{method}", context_attributes),
Expand Down
3 changes: 2 additions & 1 deletion providers/keycloak/src/airflow/providers/keycloak/auth_manager/routes/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def login_callback(request: Request):
user = KeycloakAuthManagerUser(
user_id=userinfo["sub"],
name=userinfo["preferred_username"],
access_token=tokens["access_token"],
# dont include access token in cookie to not exceed browser cookie limit of 4KB
access_token="",
refresh_token=tokens["refresh_token"],
)
token = get_auth_manager().generate_jwt(user)
Expand Down
2 changes: 1 addition & 1 deletion providers/keycloak/tests/unit/keycloak/auth_manager/routes/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_login_callback(self, mock_get_keycloak_client, mock_get_auth_manager, c
user = mock_auth_manager.generate_jwt.call_args[0][0]
assert user.get_id() == "sub"
assert user.get_name() == "preferred_username"
assert user.access_token == "access_token"
assert user.access_token == ""
assert user.refresh_token == "refresh_token"
assert response.status_code == 303
assert "location" in response.headers
Expand Down