Fix mypy error for ObjectStoragePath._from_upath classmethod_or_method typing#62855
Draft
jason810496 wants to merge 4 commits intoapache:mainfrom
Draft
Fix mypy error for ObjectStoragePath._from_upath classmethod_or_method typing#62855jason810496 wants to merge 4 commits intoapache:mainfrom
jason810496 wants to merge 4 commits intoapache:mainfrom
Conversation
jason810496
force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
2 times, most recently
from
a5ac5a7 to
34e52e7
Compare
amoghrajesh
reviewed
Mar 11, 2026
| super().__init__(*args, protocol=protocol, **storage_options) | ||
|
|
||
| @classmethod_or_method # type: ignore[arg-type] | ||
| @_classmethod_or_method |
Contributor
There was a problem hiding this comment.
This seems pretty unconventional and hard to read for little benefit. If we want to go down this route, I suggest we keep runtime import at top level
1 task
jason810496
force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
from
04c4fec to
037778f
Compare
Initial plan
…hod_or_method to classmethod under TYPE_CHECKING Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
Keep the runtime import at top level instead of behind an if/else TYPE_CHECKING block, which is more conventional and easier to read. The TYPE_CHECKING override still aliases _classmethod_or_method to classmethod for mypy. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
jason810496
force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
from
037778f to
f7919ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #62701 (comment)
Why
Follow-up Mypy fix for
ObjectStoragePath._from_upath'sclassmethod_or_methoddecorator typing.