Improve Playwright test patterns in BasePage.ts #63038#63079
Merged
choo121600 merged 2 commits intoapache:mainfrom Mar 8, 2026
Merged
Improve Playwright test patterns in BasePage.ts #63038#63079choo121600 merged 2 commits intoapache:mainfrom
choo121600 merged 2 commits intoapache:mainfrom
Conversation
choo121600
approved these changes
Mar 8, 2026
wjddn279
pushed a commit
to wjddn279/airflow
that referenced
this pull request
Mar 9, 2026
…63079) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
…63079) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
BasePage.tsto align with Playwright best practices.:has-text()withgetByRole()locatorcurrentUrlvariable inisLoggedIn()closes: #63038