Adding Russian translation for UI#63450
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
choo121600
left a comment
There was a problem hiding this comment.
Wow, adding a new language! Thanks a lot for the contribution 🙌
There was a problem hiding this comment.
Cool! A new translation 🎉
Can't vouch for the translation quality, but as per our policy this will need a translation owner, and probably a sponsor.
More information in public/i18n/README.md. Would you be willing to become a translation owner, if yes do you know if someone in the community with 'write' access to the repo would be willing to sponsor you?
Otherwise you can reach out to the mailing list to find a trusted party in the community that is willing to take ownership for rusian translation.
Code owners file need to be updated.
|
I'm willing to become a translation owner if there isn't somebody already working on a Russian translation, but to my knowledge no one left a PR similar to mine, or started a Slack discussion on the topic. I guess I'll just ask on Slack? |
|
I updated CODEOWNERS to include jscheffl as a code owner, myself as a translation owner and renat-sagut as an engaged translator since they made quite a few helpful contributions and corrections |
|
Note: CI checks are failing but this looks rather like inherited from problems on main. I assume on next push this will turn green. |
|
In general, I have some doubts that "Даг" is a good translation for DAG in Russian. I skimmed a few articles about Airflow in Russian, and most of them seem to keep the term "DAG" in English rather than transliterating it. @puzzle-rpa-team should we follow the same approach here and keep "DAG" as is? What do you think? https://practicum.yandex.ru/blog/apache-airflow/ |
|
@puzzle-rpa-team the static checks failed, as I was on it anyway I pushed some fixes. Next time please check with contribution guides and install pre-commit checks with |
# Conflicts: # .github/CODEOWNERS # airflow-core/src/airflow/ui/public/i18n/locales/ru/assets.json # airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json # airflow-core/src/airflow/ui/public/i18n/locales/ru/dashboard.json
|
Added "few" and "many" forms to the translation, also edited CODEOWNERS (now it's
Good point, but I tried to keep as much of the translation Cyrillic as possible - I thought about translating "Dag" as "НАГ", even, to keep a "directed acyclic graph" acronym. But that sounded too weird and I settled on transliterating instead. |
jscheffl
left a comment
There was a problem hiding this comment.
Cool! That looks promising!
Unfortunately there was some instability with files dev/breeze/doc/images/output_pr_auto-triage.* on main which forced you to add them to PR... and as this was fixed they (sorry) need to be re-generated on this PR (As the new language is listed there as one CLI option)
I am not an expert with Cyrillic letters... you now wrote you used "DAG" in Cyrillic letters? Correct understood?
As a community (need to find the email discussion thread if needed) we decided to refer to the term "DAG" in UI as using "Dag" (just one upper case letter) and keep "DAG" only in the class of the code (no need to migrate all Dags). Not sure if the comment by @renat-sagut referred to "Dag" or the translation that was in before. Cyrillic "Dag" would be more correct than "DAG".
The language keys now look great!
Approving... once the conflict is resolved from my side good to be merged (with above being a sanity question)
|
It looks like |
renat-sagut
left a comment
There was a problem hiding this comment.
a few more suggestions
Co-authored-by: renat-sagut <renat.sagut@gmail.com>
Co-authored-by: renat-sagut <renat.sagut@gmail.com>
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v3-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker f0018f8 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
|
NICE ! |
|
Cool! Congratulations on your first contribution and Welcome 🎉 |
* feat: added russian ui translation * fix: missing "one" and "many" for "files" * fix: added "_few" * fix: removed unused "few"'s, added "asset_many" * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * CODEOWNERS updated to include locales/ru * Update .github/CODEOWNERS * Fix static checks * CODEOWNERS fixed + replaced "Даг" with "DAG" * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * misc translation fixes * Fix ts-compile-lint-ui --------- Co-authored-by: o.marchuk <o.marchuk@mkskom.ru> Co-authored-by: renat-sagut <renat.sagut@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org>
* feat: added russian ui translation * fix: missing "one" and "many" for "files" * fix: added "_few" * fix: removed unused "few"'s, added "asset_many" * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * CODEOWNERS updated to include locales/ru * Update .github/CODEOWNERS * Fix static checks * CODEOWNERS fixed + replaced "Даг" with "DAG" * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * misc translation fixes * Fix ts-compile-lint-ui --------- Co-authored-by: o.marchuk <o.marchuk@mkskom.ru> Co-authored-by: renat-sagut <renat.sagut@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org>
* feat: added russian ui translation * fix: missing "one" and "many" for "files" * fix: added "_few" * fix: removed unused "few"'s, added "asset_many" * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * CODEOWNERS updated to include locales/ru * Update .github/CODEOWNERS * Fix static checks * CODEOWNERS fixed + replaced "Даг" with "DAG" * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * misc translation fixes * Fix ts-compile-lint-ui --------- Co-authored-by: o.marchuk <o.marchuk@mkskom.ru> Co-authored-by: renat-sagut <renat.sagut@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org>
* feat: added russian ui translation * fix: missing "one" and "many" for "files" * fix: added "_few" * fix: removed unused "few"'s, added "asset_many" * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * CODEOWNERS updated to include locales/ru * Update .github/CODEOWNERS * Fix static checks * CODEOWNERS fixed + replaced "Даг" with "DAG" * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * misc translation fixes * Fix ts-compile-lint-ui --------- Co-authored-by: o.marchuk <o.marchuk@mkskom.ru> Co-authored-by: renat-sagut <renat.sagut@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org>
* feat: added russian ui translation * fix: missing "one" and "many" for "files" * fix: added "_few" * fix: removed unused "few"'s, added "asset_many" * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ru/common.json Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * CODEOWNERS updated to include locales/ru * Update .github/CODEOWNERS * Fix static checks * CODEOWNERS fixed + replaced "Даг" with "DAG" * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * Apply suggestions from code review Co-authored-by: renat-sagut <renat.sagut@gmail.com> * misc translation fixes * Fix ts-compile-lint-ui --------- Co-authored-by: o.marchuk <o.marchuk@mkskom.ru> Co-authored-by: renat-sagut <renat.sagut@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org>

Russian UI translation was added in this PR. Unfortunately, I am not an Airflow contributor, so I cannot add a code owner to CODEOWNERS; maybe someone would be willing to step in?
Thank you to all reviewers for their time in advance!
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.