-
Notifications
You must be signed in to change notification settings - Fork 16.8k
fix: Skip dataset-triggered dags without SerializedDagModel #63546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leossantos
wants to merge
17
commits into
apache:v2-11-test
Choose a base branch
from
leossantos:leo-santos/addtional-scheduler-fix
base: v2-11-test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−1
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
75ef8b5
feat(scheduler): add INFO logging for dataset-triggered DagRun creation
leossantos 7b7e6a8
feat(scheduler): add deep diagnostic logging for dataset trigger deci…
leossantos 5fbf772
chore(scheduler): Add [DEBUG DATASETS] tag to logs
leossantos 735e145
fix(scheduler): guard against condition bypass when SerializedDagMode…
leossantos bed9938
fix(dag): remove missing_from_serialized after processing serialized …
leossantos e427302
test(models): add tests for DDRQ entries without SerializedDagModel
leossantos f59cec3
chore(scheduler): remove dataset debug logging
leossantos c626f65
fix(datasets): demote missing SerializedDagModel DDRQ log to debug
leossantos d089870
chore(datasets): debug-log when dataset condition passes in dags_need…
leossantos 36105b1
docs: add bugfix newsfragment and dags_needing_dagruns dataset docstring
leossantos 684fd2c
test(dag): persist DagModel before DatasetDagRunQueue in unit tests
leossantos 2c70fa3
test(dag): pass serialized=True in dataset dags_needing_dagruns tests
leossantos 7f25115
Apply suggestions from code review
leossantos 3c67b9f
style(dag): normalize line endings in DDRQ serialized-DAG guard block
leossantos 8561190
test(dag): align DDRQ missing-serialized log assertions with dag.py
leossantos e3198c9
test(dag): assert full DDRQ missing-serialized log line in caplog
leossantos e0425b5
chore: change missing serialized DAG log level from debug to info and…
leossantos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.