Restore nullable ORM fields and drop unreleased corrective migration#63899
Merged
ephraimbuddy merged 3 commits intoapache:mainfrom Mar 19, 2026
Merged
Restore nullable ORM fields and drop unreleased corrective migration#63899ephraimbuddy merged 3 commits intoapache:mainfrom
ephraimbuddy merged 3 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:db-migrations
ephraimbuddy
force-pushed
the
fix-nullable-orm-fields
branch
from
de3ee18 to
f3ecd1b
Compare
ashb
reviewed
Mar 18, 2026
2 tasks
ephraimbuddy
force-pushed
the
fix-nullable-orm-fields
branch
2 times, most recently
from
f54da3b to
fd4524b
Compare
PR apache#56330 mistakenly changed several ORM-backed columns from nullable to non-nullable. I later added a corrective migration in PR apache#62234 to backfill existing NULLs, but after revisiting the issue we found the migration was only compensating for the nullability mistake introduced by PR apache#56330 itself, which has not been released. Instead of shipping a large corrective migration for an unreleased regression, delete the migration file and restore the affected ORM fields to nullable so the models stay aligned with the actual schema and intended pre-release behavior.
ephraimbuddy
force-pushed
the
fix-nullable-orm-fields
branch
from
3d8b00a to
6397fec
Compare
ashb
approved these changes
Mar 19, 2026
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Looks good to me. There are some that would be "nice" to fix, but not at the cost of a 30+min migration.
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
…pache#63899) * Restore nullable ORM fields and drop unreleased corrective migration PR apache#56330 mistakenly changed several ORM-backed columns from nullable to non-nullable. I later added a corrective migration in PR apache#62234 to backfill existing NULLs, but after revisiting the issue we found the migration was only compensating for the nullability mistake introduced by PR apache#56330 itself, which has not been released. Instead of shipping a large corrective migration for an unreleased regression, delete the migration file and restore the affected ORM fields to nullable so the models stay aligned with the actual schema and intended pre-release behavior. * Return some not nullable fixes * fixup! Return some not nullable fixes
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…pache#63899) * Restore nullable ORM fields and drop unreleased corrective migration PR apache#56330 mistakenly changed several ORM-backed columns from nullable to non-nullable. I later added a corrective migration in PR apache#62234 to backfill existing NULLs, but after revisiting the issue we found the migration was only compensating for the nullability mistake introduced by PR apache#56330 itself, which has not been released. Instead of shipping a large corrective migration for an unreleased regression, delete the migration file and restore the affected ORM fields to nullable so the models stay aligned with the actual schema and intended pre-release behavior. * Return some not nullable fixes * fixup! Return some not nullable fixes
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…pache#63899) * Restore nullable ORM fields and drop unreleased corrective migration PR apache#56330 mistakenly changed several ORM-backed columns from nullable to non-nullable. I later added a corrective migration in PR apache#62234 to backfill existing NULLs, but after revisiting the issue we found the migration was only compensating for the nullability mistake introduced by PR apache#56330 itself, which has not been released. Instead of shipping a large corrective migration for an unreleased regression, delete the migration file and restore the affected ORM fields to nullable so the models stay aligned with the actual schema and intended pre-release behavior. * Return some not nullable fixes * fixup! Return some not nullable fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #56330 mistakenly changed several ORM-backed columns from nullable to non-nullable. I later added a corrective migration in PR #62234 to backfill existing NULLs, but after revisiting the issue we found the migration was only compensating for the nullability mistake introduced by PR #56330 itself, which has not been released.
Instead of shipping a large corrective migration for an unreleased regression, delete the migration file and restore the affected ORM fields to nullable so the models stay aligned with the actual schema and intended pre-release behavior.