Skip to content

Simplify Helm Chart Logic & Misc#63957

Merged
jscheffl merged 7 commits intoapache:mainfrom
Miretpl:simplify-chart
Mar 28, 2026
Merged

Simplify Helm Chart Logic & Misc#63957
jscheffl merged 7 commits intoapache:mainfrom
Miretpl:simplify-chart

Conversation

@Miretpl
Copy link
Copy Markdown
Contributor

@Miretpl Miretpl commented Mar 19, 2026

During searching of possible things missed in #61018 (this is the last PR regarding it), I didn't find any missed places, but I've found places where some things could be a little improved and/or simplified. This PR consist of:

  1. Fixing some chart formatting
  2. Simplifies some logic statements and/or combines them
  3. Reorders Kubernetes Environment Variables to have at the top values which are always present
  4. Removal of some unneeded comments in the code

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 19, 2026
@Miretpl Miretpl marked this pull request as ready for review March 20, 2026 08:45
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Cleanup is always great!

@jscheffl
Copy link
Copy Markdown
Contributor

Will merge post 1.20.0 release

@jscheffl jscheffl added this to the Airflow Helm Chart 1.21.0 milestone Mar 20, 2026
@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented Mar 28, 2026

Could we merge this one? 😄

@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Mar 28, 2026
@jscheffl jscheffl merged commit cfe4d2b into apache:main Mar 28, 2026
147 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 28, 2026
* Modify formatting

* Simplify & combine logic statements

* Move conditional envs to the bottom

* Adjust tests

* Remove some unneeded commants from scheduler
(cherry picked from commit cfe4d2b)

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>
@github-actions
Copy link
Copy Markdown

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request Mar 28, 2026
* Modify formatting

* Simplify & combine logic statements

* Move conditional envs to the bottom

* Adjust tests

* Remove some unneeded commants from scheduler
(cherry picked from commit cfe4d2b)

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>
@Miretpl Miretpl deleted the simplify-chart branch March 28, 2026 22:05
sunny7712 pushed a commit to sunny7712/airflow that referenced this pull request Mar 29, 2026
* Modify formatting

* Simplify & combine logic statements

* Move conditional envs to the bottom

* Adjust tests

* Remove some unneeded commants from scheduler
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Mar 30, 2026
* Modify formatting

* Simplify & combine logic statements

* Move conditional envs to the bottom

* Adjust tests

* Remove some unneeded commants from scheduler
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
* Modify formatting

* Simplify & combine logic statements

* Move conditional envs to the bottom

* Adjust tests

* Remove some unneeded commants from scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants