Skip to content

Add explicit type annotations to k8s code to fix mypy#64260

Merged
amoghrajesh merged 1 commit intoapache:mainfrom
amoghrajesh:mypy-k8s-2
Mar 26, 2026
Merged

Add explicit type annotations to k8s code to fix mypy#64260
amoghrajesh merged 1 commit intoapache:mainfrom
amoghrajesh:mypy-k8s-2

Conversation

@amoghrajesh
Copy link
Copy Markdown
Contributor


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

mypy was inferring the kwargs dictionaries as dict[str, str] because all initial values were strings. When unpacking these into methods with parameters of various types mypy raised type errors in https://github.com/apache/airflow/actions/runs/23595152431/job/68712850884?pr=64148

Added explicit dict[str, Any] type annotations to both kwargs dictionaries to fix it.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Mar 26, 2026
@amoghrajesh amoghrajesh requested review from Lee-W and potiuk March 26, 2026 14:37
@amoghrajesh
Copy link
Copy Markdown
Contributor Author

Unrelated failures. Merging.

@amoghrajesh amoghrajesh merged commit cc9abce into apache:main Mar 26, 2026
109 of 111 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Mar 30, 2026
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants