Fix variable import to correctly handle falsy values#64362
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 30, 2026
Merged
Fix variable import to correctly handle falsy values#64362potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
henry3260
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
henry3260
force-pushed
the
fix-edge-case-in-cli-import
branch
from
1c5ee8b to
3503f5d
Compare
potiuk
approved these changes
Mar 30, 2026
potiuk
added
the
backport-to-v3-2-test
|
Hi maintainer, this PR was merged without a milestone set.
|
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When importing variables from a JSON file using the dict format like
(
{"mykey": {"value": ""}}), falsy values such as empty string (""),0, orFalsewere incorrectly handled. The code usedv.get("value")in a truthy check, causing the entire dict to be treated as the value instead
of extracting the actual (falsy) value. This led to incorrect data being
imported.
This bug affected users who store empty strings, zero values, or boolean
falsein variables via the CLI import command.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.