Skip to content

Fix newsfragment check being cancelled on rapid PR events#64447

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-newsfragment-check-cancellation
Mar 30, 2026
Merged

Fix newsfragment check being cancelled on rapid PR events#64447
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-newsfragment-check-cancellation

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Mar 30, 2026

Change cancel-in-progress from true to false in the
check-newsfragment-pr-number workflow's concurrency group.

With cancel-in-progress: true, when a PR receives multiple events
in quick succession (e.g. a push followed by a label change, or
rapid consecutive pushes), the earlier run gets cancelled by the
newer one, leaving a spurious "Cancelled" status on the PR.

This check is extremely lightweight (a single gh api call that
runs in seconds), so queueing concurrent runs has no downside
and avoids the cancelled status issue.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Opus 4.6)

Generated-by: Claude Code (Claude Opus 4.6) following the guidelines

Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
@potiuk potiuk force-pushed the fix-newsfragment-check-cancellation branch from c102e88 to d5d5f5f Compare March 30, 2026 02:13
@potiuk potiuk merged commit 7e29628 into apache:main Mar 30, 2026
144 of 145 checks passed
@potiuk potiuk deleted the fix-newsfragment-check-cancellation branch March 30, 2026 18:05
@github-project-automation github-project-automation bot moved this from Backlog to Done in Airflow Registry Mar 30, 2026
github-actions bot pushed a commit that referenced this pull request Mar 30, 2026
…#64447)

Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
(cherry picked from commit 7e29628)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link
Copy Markdown

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

potiuk added a commit that referenced this pull request Apr 1, 2026
…#64447) (#64495)

Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
(cherry picked from commit 7e29628)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Apr 3, 2026
Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
vatsrahul1001 pushed a commit that referenced this pull request Apr 8, 2026
…#64447) (#64495)

Change cancel-in-progress from true to false so that concurrent
runs queue instead of cancelling each other. This check is very
lightweight (single API call) so queueing has no downside, and
avoids spurious "Cancelled" status on PRs that receive multiple
events in quick succession (e.g. push + label change).
(cherry picked from commit 7e29628)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants