[v3-2-test] Return 410 Gone for heartbeat when cleared TI exists in TIH (#61631)#64693
Merged
[v3-2-test] Return 410 Gone for heartbeat when cleared TI exists in TIH (#61631)#64693
Conversation
…IH (#61631) * Return 410 Gone for heartbeat when TI was cleared and moved to TIH When a running task instance is cleared, its previous try is archived to the Task Instance History table and the TI receives a new UUID. Subsequent heartbeats from the old process get a 404 because the old UUID no longer exists in the TI table. This change improves the error handling by checking the TIH table when a heartbeat TI is not found. If the UUID exists in TIH, return 410 Gone instead of 404 Not Found, giving the client a more specific signal that the task was cleared rather than never existing. - Server: check TIH on heartbeat NoResultFound, return 410 if found - Supervisor: handle 410 Gone same as 404/409 (terminate process) - Keep 404 for TIs that genuinely never existed closes: #53140 * Update task_instances.py Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Update task_instances.py Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Update test_task_instances.py Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * fix(api): use task_instance_id in heartbeat 410 path and align detail message - Replace undefined ti_id_str with task_instance_id in TIH query and log - Use task_instance_id (UUID) for TIH.task_instance_id comparison - Set 410 Gone detail message to match test expectation --------- (cherry picked from commit ce1270b) Co-authored-by: André Ahlert <andre@aex.partners> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Contributor
|
Leaveing as draft until 3.2.0 released. |
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 8, 2026
…IH (#61631) (#64693) * Return 410 Gone for heartbeat when TI was cleared and moved to TIH When a running task instance is cleared, its previous try is archived to the Task Instance History table and the TI receives a new UUID. Subsequent heartbeats from the old process get a 404 because the old UUID no longer exists in the TI table. This change improves the error handling by checking the TIH table when a heartbeat TI is not found. If the UUID exists in TIH, return 410 Gone instead of 404 Not Found, giving the client a more specific signal that the task was cleared rather than never existing. - Server: check TIH on heartbeat NoResultFound, return 410 if found - Supervisor: handle 410 Gone same as 404/409 (terminate process) - Keep 404 for TIs that genuinely never existed closes: #53140 * Update task_instances.py * Update task_instances.py * Update test_task_instances.py * fix(api): use task_instance_id in heartbeat 410 path and align detail message - Replace undefined ti_id_str with task_instance_id in TIH query and log - Use task_instance_id (UUID) for TIH.task_instance_id comparison - Set 410 Gone detail message to match test expectation --------- (cherry picked from commit ce1270b) Co-authored-by: André Ahlert <andre@aex.partners> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a running task instance is cleared, its previous try is archived
to the Task Instance History table and the TI receives a new UUID.
Subsequent heartbeats from the old process get a 404 because the old
UUID no longer exists in the TI table.
This change improves the error handling by checking the TIH table when
a heartbeat TI is not found. If the UUID exists in TIH, return 410
Gone instead of 404 Not Found, giving the client a more specific
signal that the task was cleared rather than never existing.
closes: #53140
Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com
Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com
Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com
(cherry picked from commit ce1270b)
Co-authored-by: André Ahlert andre@aex.partners
Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com