add more debugging logs when emr_eks system tests fail#64817
Open
ferruzzi wants to merge 2 commits intoapache:mainfrom
Open
add more debugging logs when emr_eks system tests fail#64817ferruzzi wants to merge 2 commits intoapache:mainfrom
ferruzzi wants to merge 2 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
ramitkataria
approved these changes
Apr 6, 2026
o-nikolas
reviewed
Apr 7, 2026
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
We already have some shared code to do this on the other EKS tests. If you look at the usage of this thing it's used for every EKS test except the one you updated. Should we not just re-use this existing code?
Contributor
Author
|
@o-nikolas That one requires a pod name which the other EKS tests get from XComs but the EMR one doesn't have, and the EMR one uses a namespace instead. I could modify that one to make pod_name optional, add an optional namespace, and a bit of logic to assert that one and one one of those is provided This felt slightly cleaner rather than modifying good existing code for a (unique?) edge case, but I can modify the existing helper. I'll change it up in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This system tests has been failing intermittently and the log outputs are not very helpful. Adding a new step that will print cluster details when (and only when) one of the steps fails.
Example output from the new task is pretty verbose, but it beats not having anything to work from:
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.