fix(triggerer): fix thread-safety in TriggerCommsDecoder.asend()#64869
Open
kalluripradeep wants to merge 1 commit intoapache:mainfrom
Open
fix(triggerer): fix thread-safety in TriggerCommsDecoder.asend()#64869kalluripradeep wants to merge 1 commit intoapache:mainfrom
kalluripradeep wants to merge 1 commit intoapache:mainfrom
Conversation
kalluripradeep
force-pushed
the
fix/triggerer-comms-threadsafe
branch
from
810fc59 to
93552c2
Compare
kalluripradeep
force-pushed
the
fix/triggerer-comms-threadsafe
branch
3 times, most recently
from
02bc550 to
867f4ad
Compare
Swapped the loop-bound asyncio lock for an asynchronous threading lock in TriggerCommsDecoder.asend() to ensure thread-safety across different event loops (e.g., from sync_to_async in triggers). Added a drain() call for reliable message delivery. Includes a new high-concurrency unit test with a robust manual writer mock and socket mock to verify isolation and prevent CI regressions. Closes apache#64620
kalluripradeep
force-pushed
the
fix/triggerer-comms-threadsafe
branch
from
867f4ad to
840c212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64620 fix: TriggerCommsDecoder.asend() asyncio.Lock is not thread-safe
Description
The
TriggerCommsDecoderused anasyncio.Lockto protect access to the communication socket. When called from a different event loop (e.g., viasync_to_asyncinside a trigger),asyncio.Lockwould either fail to provide mutual exclusion or raise aRuntimeError.This PR replaces the
asyncio.Lockwith an asynchronously-acquiredthreading.Lock, which is safe across all threads and loops. It also adds an explicitdrain()to ensure reliability.Changes
asyncio.Lockwiththreading.Lockacquired viarun_in_executor.await self._async_writer.drain()toasend()to ensure reliable message delivery.