Fix GitDagBundle submodule clone not using SSH settings from connection#64879
Open
shunsuke-sugita wants to merge 1 commit intoapache:mainfrom
Open
Fix GitDagBundle submodule clone not using SSH settings from connection#64879shunsuke-sugita wants to merge 1 commit intoapache:mainfrom
shunsuke-sugita wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GitDagBundlenow wrapsgit submodule sync/submodule updatewithGIT_SSH_COMMANDfrom the Git connection (via GitPythoncustom_environment), using the worktreeRepo(self.repo.git), not the bare mirror.Why
configure_hook_env()populateshook.env, and bare clone passes it withclone_from(..., env=...). Submodule commands are separate Git subprocesses and did not receiveGIT_SSH_COMMAND, so SSH URLs in.gitmodulescould fail (host key / identity) even when the main repo clone worked.Example failure (before this fix)
Submodule update could fail with errors such as:
Notes
_fetch_bare_repofororigin.fetchon the bare repo.submodules=True; no behavior change to other bundle modes.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.