[v3-2-test] Registry: make tomllib fallback version-aware (#66666)#66918
Open
vatsrahul1001 wants to merge 1 commit into
Open
[v3-2-test] Registry: make tomllib fallback version-aware (#66666)#66918vatsrahul1001 wants to merge 1 commit into
vatsrahul1001 wants to merge 1 commit into
Conversation
(cherry picked from commit 5b30aca)
vatsrahul1001
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66666
Conflict resolution
One conflict in `dev/registry/extract_metadata.py` (imports block). PR's after-context expected `import subprocess` to already be present from an earlier change not in v3-2-test, and adds `import sys` next to it. Took PR side but dropped `import subprocess` since it isn't used anywhere in the file on v3-2-test (would be a lint failure). Kept `import sys` (needed for the new `sys.version_info >= (3, 11)` tomllib check).
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines