Repository navigation
Make kinit renewable lifetime configurable for Heimdal Kerberos support - #67804
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
0b0f84d to
9c18849
Compare
|
Hi everyone, I have updated the core Kerberos code logic along with its corresponding documentation. To ensure everything is fully verified, I simulated the checks and ran the tests locally inside the Breeze Docker environment:
The implementation and documentation are fully verified locally and ready for review! |
cccba86 to
8dc9b5d
Compare
0796e10 to
8f2acc0
Compare
|
@potiuk Hi Jarek, I have updated |
Updated version_added for renewable lifetime option in kinit command from 3.0.0 to 3.3.0.
|
Hi @potiuk, I have updated the branch to keep it in sync with the base branch. Could you please approve the workflows to run whenever you have a moment? The PR will be ready for your review right after. Thank you! |
potiuk
left a comment
There was a problem hiding this comment.
Two things before this can go in — the code itself looks good:
- Version: correcting my earlier comment — I'd said
3.3.0, but this didn't make the 3.3.0 cut (it's already branched), so as a new feature it belongs inversion_added: 3.4.0. Please bump it. - Title: the
feat:prefix is Conventional Commits, which apache/airflow doesn't use — please drop it (e.g. "Make kinit renewable lifetime configurable for Heimdal Kerberos support").
Not approving until the version is corrected; otherwise this is ready.
This review was drafted by an AI-assisted tool and confirmed by an Airflow maintainer. The findings below are observations, not blockers; an Airflow maintainer — a real person — will take the next look at the PR. If you think a finding is mis-applied, please reply on the PR and a maintainer will weigh in.
More on how Airflow handles maintainer review: contributing-docs/05_pull_requests.rst.
Updated version_added for renewable lifetime option in kinit command.
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #26438
This PR adds a new configuration option
include_renewal_lifetimeunder the[kerberos]section. This allows deployments using Kerberos implementations that do not support the-rflag (such as Heimdal Kerberos) to disable it, while maintaining complete backward compatibility for MIT Kerberos users.Unit tests have also been added to verify the generated
kinitcommand for both configurations (True and False).