Skip to content

Make kinit renewable lifetime configurable for Heimdal Kerberos support - #67804

Merged
potiuk merged 8 commits into
apache:mainfrom
KenanAdel:main
Jul 3, 2026
Merged

potiuk merged 8 commits into
apache:mainfrom
KenanAdel:main

Conversation

@KenanAdel

@KenanAdel KenanAdel commented May 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes: #26438

This PR adds a new configuration option include_renewal_lifetime under the [kerberos] section. This allows deployments using Kerberos implementations that do not support the -r flag (such as Heimdal Kerberos) to disable it, while maintaining complete backward compatibility for MIT Kerberos users.

Unit tests have also been added to verify the generated kinit command for both configurations (True and False).

@boring-cyborg

boring-cyborg Bot commented May 31, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@KenanAdel KenanAdel mentioned this pull request May 31, 2026
1 of 2 tasks
@KenanAdel
KenanAdel force-pushed the main branch 8 times, most recently from 0b0f84d to 9c18849 Compare June 2, 2026 19:52
@KenanAdel

Copy link
Copy Markdown
Contributor Author

Hi everyone,

I have updated the core Kerberos code logic along with its corresponding documentation.

To ensure everything is fully verified, I simulated the checks and ran the tests locally inside the Breeze Docker environment:

  1. Unit Tests: All 12 Kerberos unit tests passed successfully:
    ================ 12 passed, 1 warning in 133.55s (0:02:13) ================

  2. Documentation Build: Verified locally using breeze build-docs apache-airflow. The core documentation builds successfully now (build succeeded). The previous 2244 errors are completely resolved. (Note: Any remaining local collection/intersphinx warnings are just due to missing provider inventory caches on my standalone local setup, which the remote CI handles automatically).

The implementation and documentation are fully verified locally and ready for review!

@KenanAdel
KenanAdel force-pushed the main branch 7 times, most recently from cccba86 to 8dc9b5d Compare June 3, 2026 19:24
@KenanAdel
KenanAdel force-pushed the main branch 2 times, most recently from 0796e10 to 8f2acc0 Compare June 3, 2026 21:57
@KenanAdel

Copy link
Copy Markdown
Contributor Author

@potiuk Hi Jarek,

I have updated kerberos.py directly to fix the Python bracket formatting issue caught by the static checks. The PR is now ready for your review and workflow approval. Thank you!

@KenanAdel
KenanAdel requested a review from potiuk June 3, 2026 22:10
@potiuk potiuk added the ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green. label Jun 3, 2026
Updated version_added for renewable lifetime option in kinit command from 3.0.0 to 3.3.0.
@KenanAdel

Copy link
Copy Markdown
Contributor Author

Hi @potiuk, I have updated the branch to keep it in sync with the base branch. Could you please approve the workflows to run whenever you have a moment? The PR will be ready for your review right after. Thank you!

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things before this can go in — the code itself looks good:

  • Version: correcting my earlier comment — I'd said 3.3.0, but this didn't make the 3.3.0 cut (it's already branched), so as a new feature it belongs in version_added: 3.4.0. Please bump it.
  • Title: the feat: prefix is Conventional Commits, which apache/airflow doesn't use — please drop it (e.g. "Make kinit renewable lifetime configurable for Heimdal Kerberos support").

Not approving until the version is corrected; otherwise this is ready.


This review was drafted by an AI-assisted tool and confirmed by an Airflow maintainer. The findings below are observations, not blockers; an Airflow maintainer — a real person — will take the next look at the PR. If you think a finding is mis-applied, please reply on the PR and a maintainer will weigh in.

More on how Airflow handles maintainer review: contributing-docs/05_pull_requests.rst.

@KenanAdel KenanAdel changed the title feat: Make kinit renewable lifetime configurable for Heimdal Kerberos support Make kinit renewable lifetime configurable for Heimdal Kerberos support Jul 3, 2026
Updated version_added for renewable lifetime option in kinit command.
@KenanAdel
KenanAdel requested a review from potiuk July 3, 2026 13:18
@potiuk
potiuk merged commit 0211b90 into apache:main Jul 3, 2026
78 checks passed
@boring-cyborg

boring-cyborg Bot commented Jul 3, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ConfigTemplates ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kerberos : switch MIT to Heimdal

2 participants