Repository navigation
Add deadlines to Calendar Tab - #69559
Merged
Merged
Conversation
- Added support for displaying deadlines in the calendar view, including missed and pending deadlines. - Updated Calendar components to fetch and display deadline data from the new API endpoint. - Introduced visual indicators for deadlines in Calendar cells and tooltips. - Enhanced CalendarLegend to show deadline status and counts. - Refactored calendar utility functions to handle deadline data aggregation. This update improves user visibility into task deadlines within the DAG calendar interface.
- Moved the LegendIcon component from CalendarLegend.tsx to a new file LegendIcon.tsx for better modularity and readability. - Updated CalendarLegend to import and utilize the new LegendIcon component, streamlining the code structure. - The LegendIcon component handles rendering of color indicators for calendar items, supporting both mixed and single color states. This refactor enhances maintainability and clarity in the Calendar UI components.
imrichardwu
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 7, 2026 15:32
boring-cyborg
Bot
added
area:translations
area:UI
imrichardwu
marked this pull request as draft
July 8, 2026 05:29
imrichardwu
marked this pull request as ready for review
July 8, 2026 05:29
bbovenzi
reviewed
Jul 8, 2026
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
I think the small orange/red dot is hard to read especially on a red calendar square. What if we used an icon instead? Kind of like how we have icons in the grid view. Then we also don't need to hardcode red.500 and orange.400
- Removed the "Deadlines" label from the i18n JSON file to streamline translations. - Updated CalendarCell to use icons for missed and pending deadlines instead of colored dots, improving visual clarity. - Modified CalendarLegend and CalendarTooltip to reflect the new icon-based representation for deadline statuses. - Introduced a new utility function to build a deadline date map, enhancing the handling of deadline data in the calendar. - Updated datetime utility functions to support consistent date formatting across the calendar components.
Contributor
|
Let's remove the absolute corner positioning. We can have the icon be larger and centered in the calendar square. It can also just be the regular fg color no need for blue or red lines. |
imrichardwu
marked this pull request as draft
July 8, 2026 21:32
imrichardwu
force-pushed
the
feat/calendar
branch
from
July 9, 2026 01:26
aeda313 to
f36bade
Compare
imrichardwu
marked this pull request as ready for review
July 9, 2026 01:32
Contributor
|
Great. Let's just get rid of the colors of the upcoming and missed icons now in the legend and tooltip. |
Contributor
Author
So we only want the warning on the heat map? If so any reason why? I’m just curious as I’m trying to improve my ui/ux. |
Contributor
|
No I mean that the icons themselves are blue and pink. That isn't necessary, and is hard to read on the white background. Now when to show either icons. I think we can have a priority list like we do for task groups:
|
1 task
potiuk
added
the
ready for maintainer review
bbovenzi
approved these changes
Jul 13, 2026
joshuabvarghese
pushed a commit
to joshuabvarghese/airflow
that referenced
this pull request
Jul 16, 2026
* Enhance Calendar UI with Deadline Features - Added support for displaying deadlines in the calendar view, including missed and pending deadlines. - Updated Calendar components to fetch and display deadline data from the new API endpoint. - Introduced visual indicators for deadlines in Calendar cells and tooltips. - Enhanced CalendarLegend to show deadline status and counts. - Refactored calendar utility functions to handle deadline data aggregation. This update improves user visibility into task deadlines within the DAG calendar interface. * Refactor Calendar Legend Component and Extract LegendIcon - Moved the LegendIcon component from CalendarLegend.tsx to a new file LegendIcon.tsx for better modularity and readability. - Updated CalendarLegend to import and utilize the new LegendIcon component, streamlining the code structure. - The LegendIcon component handles rendering of color indicators for calendar items, supporting both mixed and single color states. This refactor enhances maintainability and clarity in the Calendar UI components. * Refactor Calendar Components and Enhance Deadline Indicators - Removed the "Deadlines" label from the i18n JSON file to streamline translations. - Updated CalendarCell to use icons for missed and pending deadlines instead of colored dots, improving visual clarity. - Modified CalendarLegend and CalendarTooltip to reflect the new icon-based representation for deadline statuses. - Introduced a new utility function to build a deadline date map, enhancing the handling of deadline data in the calendar. - Updated datetime utility functions to support consistent date formatting across the calendar components. * Updated the styling of the deadline indicator and adjusted properties * Refactor Calendar Components to Remove Color Properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pending and missed deadline indicators to the Calendar view. The Calendar view previously had no way to see whether a Dag's deadlines were being met.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Important
🛠️ Maintainer triage note for @imrichardwu · by
@potiuk· 2026-07-08 15:38 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
CI image checks / Static checks,CI image checks / Static checks). See the contributor guide.Full criteria: Pull Request quality criteria.
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.