Repository navigation
Add task log message when the Execution API is unreachable - #70290
Merged
kaxil merged 4 commits intoOct 12, 2026
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
karenhsieh75
force-pushed
the
fix-empty-log-on-connection-error
branch
from
August 2, 2026 05:07
9b28bfd to
644b1b2
Compare
Contributor
Author
|
@guan404ming Could you please help review this? Thanks! |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
Bot
added
the
stale
guan404ming
approved these changes
Sep 30, 2026
Member
|
I think we could remove those inline code comments here, thanks! |
guan404ming
force-pushed
the
fix-empty-log-on-connection-error
branch
from
September 30, 2026 12:41
644b1b2 to
64c7ecb
Compare
Resolve the conflict in supervise_task by keeping both handlers: the TaskLaunchError handler added on main, then this branch's httpx.RequestError handler.
Drop the inline comments in the httpx.RequestError handler, as asked in review, and give the test's coordinator, logger and log file mocks a spec or autospec.
Write the task log to a temporary folder and read it back, as the launch-failure tests do, instead of mocking _configure_logging. The test now also checks that the group is closed before the error.
kaxil
approved these changes
Oct 8, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A supervisor connection failure to the Execution API only showed up in the executor's stdout. As a result, UI users only saw a failed task with an empty log, making it difficult to identify the root cause.
How
httpx.RequestErrorinsupervise_taskand log the failure (with the relevant config to check) to the task's own log before re-raisingrelated: #51163
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5) following the guidelines