Repository navigation
Add missing Druid Ingest connection type - #72104
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
7a41d66 to
945b0b7
Compare
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
DruidHookis on that list but it's not finished.DruidHookdidn't declareconn_type, so "Druid Ingest" was missing from the connection type dropdown.druid_ingest_defaultconnection usedconn_type="druid", and the hook usesconn_typeas the URL scheme, so it produceddruid://druid-overlord:8081/...andrequestsraisedInvalidSchema.How
conn_name_attr,default_conn_name,conn_typeandhook_nameonDruidHook, and registerdruid_ingestinprovider.yaml.get_connection_type()no longer returns the hook's ownconn_typeas a URL scheme, sodruid_ingestfalls back tohttp. Any otherconn_typestill passes through, so connections that set it tohttpskeep working.druid_ingest_defaultconnection withconn_type="druid_ingest"so it builds a usable URL.Verification
uv run --project providers/apache/druid pytest providers/apache/druid/tests/unit -xvsuv run --project airflow-core pytest airflow-core/tests/unit/utils/test_db.py -xvsWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.