Skip to content

Avoid retrying XCom expand actions - #72305

Merged
bbovenzi merged 1 commit into
apache:mainfrom
huyua9:fix/xcom-expand-collapse-retry
Sep 9, 2026
Merged

bbovenzi merged 1 commit into
apache:mainfrom
huyua9:fix/xcom-expand-collapse-retry

Conversation

@huyua9

@huyua9 huyua9 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Move the XCom expand action out of the Playwright retry callback so a transient assertion does not click the action repeatedly. The test now waits for the button, clicks it once, and retries only the resulting visibility assertion.

This addresses the expand/collapse pattern tracked by #63036 and keeps the change limited to the XCom page object.

Validation:

  • git diff --check
  • prek install was attempted; hook initialization was blocked by a transient network failure while fetching codespell.

Was generative AI tooling used to co-author this PR?
  • Yes — OpenAI Codex

Generated-by: OpenAI Codex following the guidelines

Drafted-by: OpenAI Codex (no human review before posting)

@boring-cyborg

boring-cyborg Bot commented Aug 31, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 31, 2026
@bbovenzi
bbovenzi merged commit 03a6b85 into apache:main Sep 9, 2026
85 of 87 checks passed
@boring-cyborg

boring-cyborg Bot commented Sep 9, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Sep 11, 2026
Co-authored-by: ming <silverchris@foxmail.com>
xvega pushed a commit to xvega/airflow that referenced this pull request Sep 13, 2026
Co-authored-by: ming <silverchris@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants