Repository navigation
More human readable duration strings - #72350
Merged
bbovenzi merged 4 commits intoSep 9, 2026
Merged
Conversation
bbovenzi
requested review from
pierrejeambrun and
ryanahamilton
as code owners
August 31, 2026 20:49
bbovenzi
requested review from
choo121600,
guan404ming,
shubhamraj-git and
vatsrahul1001
as code owners
August 31, 2026 20:49
ryanahamilton
left a comment
ryanahamilton
left a comment
Contributor
There was a problem hiding this comment.
Read through the whole diff and ran the checks locally. The core band logic in getDurationParts is solid — I probed the boundaries hard (0.9996, 59.95, 3599.6, 86399.4, …) and the carry is correct at every one of them. I also pushed all 21 shipped locales through both Intl.NumberFormat(style: "unit") and Intl.ListFormat, narrow and long, with no throws. The move off zero-padded clock strings is a clear improvement, and driving the format from CLDR with no new translation keys is the right way to get there.
Local results, on 4b6f540:
| Check | Result |
|---|---|
pnpm exec tsc --p tsconfig.app.json |
pass |
pnpm exec eslint --quiet |
pass |
pnpm exec vitest run |
1150/1151 — the single failure, DateTimeInput.test.tsx, is an unrelated 5s timeout that passes in isolation |
One thing I'd call a bug, on getRelativeTime — it prints 60 minutes ago / 24 hours ago / 12 months ago where fromNow() said an hour ago / a day ago / a year ago. Details inline. The rest are layout budgets that were tuned for the always-English "1h 2m" and are now tight in the wider locales, plus some cleanup.
Three notes that don't anchor to a changed line:
src/utils/index.ts:21still re-exportsgetDuration/renderDuration. After this PR nothing imports them from the barrel, anduseDurationFormat's own doc says components must not use the raw functions — dropping the re-export would close the escape hatch the hook exists to eliminate.Backfills.tsxtakesformatElapsedas a third positional argument togetColumns, where the siblingDagRuns/TaskInstancescolumn builders take an options object. Trivial, but the three read differently now.- Newsfragment — there isn't one. This changes how every duration in the UI renders, so it may be worth an
airflow-core/newsfragments/72350.improvement.rst; entirely your call on whether it clears the user-facing bar.
bbovenzi
force-pushed
the
dev/timestamp-subsecond-durations-191d7e
branch
from
September 1, 2026 13:55
4b6f540 to
da399ed
Compare
ryanahamilton
approved these changes
Sep 8, 2026
ryanahamilton
left a comment
ryanahamilton
left a comment
Contributor
There was a problem hiding this comment.
Had one more small comment and looks like you have a merge conflict. Overall looks like a nice enhancement.
Contributor
|
@bbovenzi can you resolve conflicts |
Zero-padded clock strings buried the one number that mattered: a task that took 83ms read as 00:00:00.083, and anything under a second rendered as 00:00:00 in chart tooltips and Gantt axis labels, which is indistinguishable from no time at all. Someone scanning a column of durations wants the magnitude at a glance, and roughly three significant digits gives it to them at every scale from milliseconds to days. Unit names, decimal separators and plural forms now come from CLDR through Intl rather than being hardcoded English, so durations follow the language the rest of the UI is already using. This needs no new translation keys, and it reproduces Intl.DurationFormat's narrow style without requiring it, since that API is above this package's Node floor. Formatting goes through a hook bound to the active language because reading the language straight off the i18next singleton put it outside anything React tracks: a component with no reason of its own to subscribe to a language change kept rendering the previous locale indefinitely.
Relative times picked their unit from the unrounded gap and then rounded inside it, so anything just short of the next unit printed that unit's own ceiling: "60 minutes ago" where "an hour ago" was meant, and the same at 24 hours and 12 months. Promoting after the rounding matches what the duration path already does a few hundred lines up. Two layout budgets were sized when every duration was the English "1h 2m" and are too tight now that CLDR decides the width: the bar-end labels on the slowest-task chart reserved a fixed 64px, and the Gantt axis derived its tick spacing from an eight-character "HH:MM:SS" estimate. German narrow needs roughly half again as much room. The Gantt axis also placed ticks at evenly divided raw values, which the old truncating format hid; at this precision a seven-second span read 0s | 1.17s | 2.33s. Snapping to the same counted units the other duration axes use keeps short spans legible. Rounding to two units leaves "1h 2m" covering a full minute, which is too coarse to tell two similar runs apart in a list. The exact value now rides along in a title on the duration columns, so the compact form stays scannable without giving up the precise number.
The hook was the only util under src/utils that callers had to reach by its own path, so consumers imported it differently from every other util sitting beside it. Routing it through the barrel leaves one way in. The Dag overview test replaces the barrel wholesale rather than patching it, so it has to name the hook for the components under test to keep resolving.
bbovenzi
force-pushed
the
dev/timestamp-subsecond-durations-191d7e
branch
from
September 9, 2026 18:22
da399ed to
d9ceadd
Compare
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
* UI: Show durations in a readable, localized format Zero-padded clock strings buried the one number that mattered: a task that took 83ms read as 00:00:00.083, and anything under a second rendered as 00:00:00 in chart tooltips and Gantt axis labels, which is indistinguishable from no time at all. Someone scanning a column of durations wants the magnitude at a glance, and roughly three significant digits gives it to them at every scale from milliseconds to days. Unit names, decimal separators and plural forms now come from CLDR through Intl rather than being hardcoded English, so durations follow the language the rest of the UI is already using. This needs no new translation keys, and it reproduces Intl.DurationFormat's narrow style without requiring it, since that API is above this package's Node floor. Formatting goes through a hook bound to the active language because reading the language straight off the i18next singleton put it outside anything React tracks: a component with no reason of its own to subscribe to a language change kept rendering the previous locale indefinitely. * UI: Address duration formatting review feedback Relative times picked their unit from the unrounded gap and then rounded inside it, so anything just short of the next unit printed that unit's own ceiling: "60 minutes ago" where "an hour ago" was meant, and the same at 24 hours and 12 months. Promoting after the rounding matches what the duration path already does a few hundred lines up. Two layout budgets were sized when every duration was the English "1h 2m" and are too tight now that CLDR decides the width: the bar-end labels on the slowest-task chart reserved a fixed 64px, and the Gantt axis derived its tick spacing from an eight-character "HH:MM:SS" estimate. German narrow needs roughly half again as much room. The Gantt axis also placed ticks at evenly divided raw values, which the old truncating format hid; at this precision a seven-second span read 0s | 1.17s | 2.33s. Snapping to the same counted units the other duration axes use keeps short spans legible. Rounding to two units leaves "1h 2m" covering a full minute, which is too coarse to tell two similar runs apart in a list. The exact value now rides along in a title on the duration columns, so the compact form stays scannable without giving up the precise number. * Address PR Feedback * UI: Export useDurationFormat from the utils barrel The hook was the only util under src/utils that callers had to reach by its own path, so consumers imported it differently from every other util sitting beside it. Routing it through the barrel leaves one way in. The Dag overview test replaces the barrel wholesale rather than patching it, so it has to name the hook for the components under test to keep resolving.
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
* UI: Show durations in a readable, localized format Zero-padded clock strings buried the one number that mattered: a task that took 83ms read as 00:00:00.083, and anything under a second rendered as 00:00:00 in chart tooltips and Gantt axis labels, which is indistinguishable from no time at all. Someone scanning a column of durations wants the magnitude at a glance, and roughly three significant digits gives it to them at every scale from milliseconds to days. Unit names, decimal separators and plural forms now come from CLDR through Intl rather than being hardcoded English, so durations follow the language the rest of the UI is already using. This needs no new translation keys, and it reproduces Intl.DurationFormat's narrow style without requiring it, since that API is above this package's Node floor. Formatting goes through a hook bound to the active language because reading the language straight off the i18next singleton put it outside anything React tracks: a component with no reason of its own to subscribe to a language change kept rendering the previous locale indefinitely. * UI: Address duration formatting review feedback Relative times picked their unit from the unrounded gap and then rounded inside it, so anything just short of the next unit printed that unit's own ceiling: "60 minutes ago" where "an hour ago" was meant, and the same at 24 hours and 12 months. Promoting after the rounding matches what the duration path already does a few hundred lines up. Two layout budgets were sized when every duration was the English "1h 2m" and are too tight now that CLDR decides the width: the bar-end labels on the slowest-task chart reserved a fixed 64px, and the Gantt axis derived its tick spacing from an eight-character "HH:MM:SS" estimate. German narrow needs roughly half again as much room. The Gantt axis also placed ticks at evenly divided raw values, which the old truncating format hid; at this precision a seven-second span read 0s | 1.17s | 2.33s. Snapping to the same counted units the other duration axes use keeps short spans legible. Rounding to two units leaves "1h 2m" covering a full minute, which is too coarse to tell two similar runs apart in a list. The exact value now rides along in a title on the duration columns, so the compact form stays scannable without giving up the precise number. * Address PR Feedback * UI: Export useDurationFormat from the utils barrel The hook was the only util under src/utils that callers had to reach by its own path, so consumers imported it differently from every other util sitting beside it. Routing it through the barrel leaves one way in. The Dag overview test replaces the barrel wholesale rather than patching it, so it has to name the hook for the components under test to keep resolving.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
our duration format was dd:hh:mm:ss.ms, which for short durations had a lot of excessive zeros or with many ms had floating point overflow.
Solution:
Switch to a more human readable format string that can be set per locale
Was generative AI tooling used to co-author this PR?
Claude Opus 5
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.