Repository navigation
Test that execute_tasks_new_python_interpreter only affects the task process - #73149
Merged
Merged
Conversation
…process The existing fork+exec wiring tests patch the platform gate and check it flows through to WatchedSubprocess.start; none set the option itself. These tests set [core] execute_tasks_new_python_interpreter and assert the Dag processor, the triggerer and the callback supervisor still start their child with a bare fork.
kaxil
changed the title
execute_tasks_new_python_interpreter only affects the task process
jason810496
approved these changes
Sep 16, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for covering the test gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72164, which scoped
[core] execute_tasks_new_python_interpreterto the task process. The tests around that scope patch the platform gate,_should_use_exec(), and assert the value flows through toWatchedSubprocess.start; none of them set the option itself. A config read moved back into the shared gate, which is the shape the first revision of #72164 had, would pass the suite while switching the Dag processor and the triggerer to a fresh interpreter per fork.These tests set the option to
Trueand toFalseand assert thatDagFileProcessorProcess.start,TriggerRunnerSupervisor.startandCallbackSubprocess.startstill handuse_exec=Falseto the basestart(). The Dag processor and triggerer tests run under the existing autouse fixtures that pin the platform gate to bare fork, so they hold on macOS as well as Linux. The callback test needs no pin: its closure target can only run under a bare fork, which is what the assertion protects.