Skip to content

Block new EM102 f-string exception messages in prek - #73166

Closed
rjgoyln wants to merge 1 commit into
apache:mainfrom
rjgoyln:feat/prek-no-new-fstring-exception
Closed

rjgoyln wants to merge 1 commit into
apache:mainfrom
rjgoyln:feat/prek-no-new-fstring-exception

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Ruff's EM102 (f-string-in-exception) cannot go into extend-select: the repository carries 2478 f-string exception messages across 837 files, and rewriting them in one commit would conflict with every open pull request.

This applies the ratchet the repository already uses for raise AirflowException and for positional @provide_session arguments, so the rule binds new code while the existing occurrences are cleared at whatever pace contributors choose.

Change

  • Add check-no-new-fstring-in-exception over airflow-core, airflow-ctl, providers, shared and task-sdk.
  • Grandfather the existing occurrences as per-file counts in generated/known_fstring_exceptions.txt.
  • Tighten an entry whenever a file's count drops, so the allowlist only ever ratchets down.

Clearing an area is ruff check --select EM102 --unsafe-fixes --fix over it plus the tightened allowlist.

Tests

Detection uses ast rather than invoking ruff, so it was checked against ruff over the five scanned roots: both report 2478 occurrences in 837 files with no per-file disagreement, and they agree on implicit concatenation, placeholder-less f-strings, keyword and starred arguments, raise X(...) from err, raise X without a call, and t-strings.

A file that fails to parse counts as unknown rather than zero. Zero would read as a clean-up and delete that file's grandfathered entry, after which its pre-existing usages come back as new.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

Ruff's EM102 cannot be added to extend-select: the repository carries 2478
f-string exception messages across 837 files, and rewriting them in one go
would conflict with every open pull request. The same ratchet the repository
already uses for raise AirflowException lets the rule take effect for new code
while the existing occurrences are cleaned up at whatever pace contributors
choose.
@rjgoyln rjgoyln changed the title Block new f-string exception messages in prek Block new EM102 f-string exception messages in prek Sep 15, 2026
@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @rjgoyln - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants