Repository navigation
Conversation
Ruff's EM102 cannot be added to extend-select: the repository carries 2478 f-string exception messages across 837 files, and rewriting them in one go would conflict with every open pull request. The same ratchet the repository already uses for raise AirflowException lets the rule take effect for new code while the existing occurrences are cleaned up at whatever pace contributors choose.
|
Hello @rjgoyln - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
Ruff's
EM102(f-string-in-exception) cannot go intoextend-select: the repository carries 2478 f-string exception messages across 837 files, and rewriting them in one commit would conflict with every open pull request.This applies the ratchet the repository already uses for
raise AirflowExceptionand for positional@provide_sessionarguments, so the rule binds new code while the existing occurrences are cleared at whatever pace contributors choose.Change
check-no-new-fstring-in-exceptionoverairflow-core,airflow-ctl,providers,sharedandtask-sdk.generated/known_fstring_exceptions.txt.Clearing an area is
ruff check --select EM102 --unsafe-fixes --fixover it plus the tightened allowlist.Tests
Detection uses
astrather than invoking ruff, so it was checked against ruff over the five scanned roots: both report 2478 occurrences in 837 files with no per-file disagreement, and they agree on implicit concatenation, placeholder-less f-strings, keyword and starred arguments,raise X(...) from err,raise Xwithout a call, and t-strings.A file that fails to parse counts as unknown rather than zero. Zero would read as a clean-up and delete that file's grandfathered entry, after which its pre-existing usages come back as new.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines