Repository navigation
Stop a commented executable_resumable from marking a module durable - #73607
Merged
amoghrajesh merged 3 commits intoOct 26, 2026
Merged
Conversation
amoghrajesh
requested review from
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
September 23, 2026 11:08
Lee-W
reviewed
Sep 24, 2026
kaxil
reviewed
Oct 6, 2026
kaxil
approved these changes
Oct 6, 2026
potiuk
approved these changes
Oct 18, 2026
potiuk
reviewed
Oct 18, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
The branch doesn't allow edits from maintainers, so here are the open review points as suggestions you can apply directly. I ran dev/registry/tests/test_extract_parameters.py locally with all three applied: 95 passed. On the current head, the trailing-comment case still reports the operator as durable.
Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 26, 2026
…le durable (apache#73607) (cherry picked from commit 77da6da) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Follow-up to comments on #70298
The two capability walks disagreed about comments. The delegation walk strips them, on the grounds that a comment can say the opposite of what the code does, but the
ResumableJobMixinwalk searched raw source, so a comment namingexecute_resumablewas enough to earn the Durable badge.The origin-resolution and depth-key rules in the deferral walk were both added to fix real misdetections, and both had no test that failed without them, so either could have been reverted as a simplification without anything noticing. The cases that need them are awkward to reach by accident: a helper the class under test overrides but an ancestor calls, and a helper reached first with too little depth budget left to finish the walk.
The four
ModuleContractfield tests asserted on the dict they passed in, whichvalidate_modules_catalogreturns unchanged, so they held even with the fields deleted from the model. They now assert throughModuleContract.model_validate.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.