Repository navigation
Fix XComs e2e filter tests: scope the filter input by testid (#72438) - #73666
Merged
Merged
Conversation
* Fix XComs e2e filter tests: scope the filter input by testid
xcoms.spec.ts's filter tests locate the active filter pill's input via
page.locator("div").filter({ hasText: `${filterName}:` }), which
matches any ancestor whose descendant text contains that string.
matches, and .first() no longer reliably picks the actual pill -
getByRole("textbox") on it resolves to every textbox inside whichever
div wins, throwing "resolved to 12 elements instead of 1".
Give the actively-editing pill's input a stable data-testid
(filter-pill-input) instead of relying on ancestor text matching, and
scope XComsPage.applyFilter() to it directly. Only one pill is ever in
edit mode at a time, so the testid alone is enough - no per-filter key
plumbing needed.
Added a FilterBar test that fails without the fix (verified locally by
reverting the testid and confirming the new test - and only that
test - breaks).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015kAvbZ6SeKgp6jbGcvpXSh
* Add newsfragment
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015kAvbZ6SeKgp6jbGcvpXSh
* Revert "Add newsfragment"
This reverts commit 06fd055.
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Kunal8954 <your-github-email@example.com>
(cherry picked from commit 0f7f45f)
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
September 24, 2026 13:27
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #72438 to
v3-3-test.The XComs e2e filter tests located the active filter pill's input via
page.locator("div").filter({ hasText: \${filterName}:` }).first(), which matches an ancestor wrapping the whole table;getByRole("textbox")on it then resolved to every XCom-value Monaco editor and failed with "resolved to N elements instead of 1". This gives the actively-editing pill's input a stabledata-testid="filter-pill-input"` and targets it directly.The original PR's
FilterBar.test.tsxchange is omitted — that unit-test file does not exist onv3-3-test, so this backport carries only the e2e fix (component testid + page object).(cherry picked from commit 0f7f45f)
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines