Repository navigation
Eager-load DagCode in the Dag source API - #73752
Merged
jason810496 merged 1 commit intoSep 26, 2026
Merged
Conversation
GET /dags/{dag_id}/dagSources loaded the DagVersion first and then read
the lazy dag_code relationship, issuing a second query. Add a
load_dag_code option to DagVersion.get_version that joinedloads dag_code,
and use it from the Dag source route so the source and its language come
back in a single query.
Closes: apache#73716
Signed-off-by: Tzu-ping Chung <tp@astronomer.io>
uranusjr
requested review from
XD-DENG,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
September 26, 2026 09:29
shahar1
approved these changes
Sep 26, 2026
jason810496
approved these changes
Sep 26, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Yeah, same as what I imagined for the follow-up, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET
/dags/{dag_id}/dagSourcesloaded the DagVersion first and then read thelazy dag_coderelationship, issuing a second query.Add a
load_dag_codeoption thatjoinedloadsdag_code, and use it from the Dag source route so the source and its language come back in a single query.Close #73716.