Repository navigation
Mask XCom values in the audit log - #73791
Merged
Merged
Conversation
potiuk
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
September 27, 2026 13:23
fat-catTW
reviewed
Oct 2, 2026
potiuk
force-pushed
the
mask-xcom-values-in-audit-log
branch
from
October 4, 2026 22:12
cc33bdc to
fba6f3e
Compare
The audit log masks the value of Variable and Connection writes unconditionally, because it records that something was written rather than what. XCom create and update requests fell through to per-key name redaction, so their values were stored in the audit log as sent. Mask the XCom value the same way; the key and map index are kept. Generated-by: Claude Opus 5
Generated-by: Claude Opus 5
Replacing the path/query context with the request body dropped xcom_key, so an update_xcom_entry row no longer said which XCom was changed. Generated-by: Claude Opus 5
potiuk
force-pushed
the
mask-xcom-values-in-audit-log
branch
from
October 16, 2026 02:56
fba6f3e to
375103c
Compare
Member
Author
|
@amoghrajesh @pierrejeambrun Rebased on main to resolve a conflict. Could one of you review it for 3.4.0 (cut 2026-10-19)? |
vatsrahul1001
approved these changes
Oct 18, 2026
Contributor
There was a problem hiding this comment.
The change looks correct to me. The earlier concern about the XCom branch dropping the path/query context is fixed, since the masked body is now merged into extra_fields, and the PATCH test asserts xcom_key is kept. GET and DELETE have no body and no value key, so their audit entries are unchanged. Could use reviews from @amoghrajesh @pierrejeambrun before merging.
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
added a commit
that referenced
this pull request
Oct 19, 2026
* Mask XCom values in the audit log The audit log masks the value of Variable and Connection writes unconditionally, because it records that something was written rather than what. XCom create and update requests fell through to per-key name redaction, so their values were stored in the audit log as sent. Mask the XCom value the same way; the key and map index are kept. Generated-by: Claude Opus 5 * Add newsfragment Generated-by: Claude Opus 5 * Keep the targeted XCom in the audit log when an update has a body Replacing the path/query context with the request body dropped xcom_key, so an update_xcom_entry row no longer said which XCom was changed. (cherry picked from commit a26eb12) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
* Mask XCom values in the audit log The audit log masks the value of Variable and Connection writes unconditionally, because it records that something was written rather than what. XCom create and update requests fell through to per-key name redaction, so their values were stored in the audit log as sent. Mask the XCom value the same way; the key and map index are kept. Generated-by: Claude Opus 5 * Add newsfragment Generated-by: Claude Opus 5 * Keep the targeted XCom in the audit log when an update has a body Replacing the path/query context with the request body dropped xcom_key, so an update_xcom_entry row no longer said which XCom was changed. (cherry picked from commit a26eb12) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit log masks the value of Variable and Connection writes unconditionally, because it records that something was written rather than what. XCom create and update requests fell through to per-key name redaction, so their values were stored in the audit log as sent. This masks the XCom value the same way; the key and map index are kept. Adds unit tests for the masker and route tests asserting the stored audit entry for create and update carries
"value": "***".🤖 Generated with Claude Code