Repository navigation
Redact Connection extra fields that providers declare as secrets - #73797
Open
JelyFishhhhhh wants to merge 1 commit into
Open
JelyFishhhhhh wants to merge 1 commit into
JelyFishhhhhh wants to merge 1 commit into
Conversation
JelyFishhhhhh
requested review from
amoghrajesh,
ashb and
potiuk
as code owners
September 27, 2026 14:49
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
kaxil
reviewed
Oct 13, 2026
JelyFishhhhhh
force-pushed
the
redact-provider-declared-secrets
branch
from
October 14, 2026 01:28
82f3a70 to
bf2b95f
Compare
Member
|
@kaxil All your review points are addressed and resolved. Could you take another look? It's targeted at 3.4.0 (cut 2026-10-19). |
kaxil
reviewed
Oct 27, 2026
Providers declare these connection extra fields as secrets, but their names were missing from the redaction allowlist, so their values were not redacted like other secret fields. They are matched as whole names because, as substrings, they would also hide non-secret fields such as kube_config_path and credential_config_file.
JelyFishhhhhh
force-pushed
the
redact-provider-declared-secrets
branch
from
October 29, 2026 08:08
bf2b95f to
1cea50c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several providers declare connection extra fields as secrets (
PasswordField), but their names were missing from the redaction allowlist, so their values were not redacted like other secret fields. This adds them (app_key,certificate,credential,keytab,kube_config,oauth,routing_key,thumbprint,write_key) asDEFAULT_SENSITIVE_FIELD_NAMES, matched against the whole field name, including its camelCase form (kubeConfig) and itsextra__<conn_type>__<name>form. Matched as substrings, likeDEFAULT_SENSITIVE_FIELDS, they would also hide non-secret fields such askube_config_pathorcredential_config_file.configis deliberately not added; apprise'sconfigfield is handled separately.A regression test asserts that every field a provider declares sensitive is covered, so the allowlist and the providers do not drift apart again. apprise's
configis the one documented exception.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.