Repository navigation
Fix XCom query in not_previously_skipped_dep to use xcom_entity - #74377
Merged
potiuk merged 2 commits intoOct 7, 2026
Merged
Conversation
aaron-y-chen
marked this pull request as ready for review
October 6, 2026 23:00
yuseok89
approved these changes
Oct 7, 2026
yuseok89
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for the quick fix!
potiuk
approved these changes
Oct 7, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled canary on
main(Tests (ARM) run) fails deterministically on every core test job and on static checks. This comes from two PRs merged on the same day that conflict without a merge conflict:XComModelinto a read projection over both XCom stores. The filters ofXComModel.get_many()now live inside the aliased entity it selects, and columns added to that statement must be read throughxcom_entity(query). The same PR added thecheck-xcom-model-columnshook to enforce this._mapped_group_skip_decisions(), which projectsXComModel.task_id,XComModel.map_indexandXComModel.valueonto theget_many()statement.The base
XComModelcolumns refer to the unfiltered projection, not the filtered alias. Projecting them withwith_only_columns()and dropping the ordering removes the alias from the query, so every XCom row is read, whatever its run, Dag or key. A ShortCircuitOperator's booleanreturn_valuethen counts as a skip decision, and scheduling a task downstream of a short-circuit in a mapped task group fails withTypeError: argument of type 'bool' is not iterable. Outside the tests this also means one full XCom read per mapped task group per scheduling pass.Reading the columns through
xcom_entity(query)keeps the query on the filtered alias, as the otherget_many()callers already do.Error Msg:
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus-5.5] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.