Repository navigation
Enforce execution_timeout on stub tasks run by a language SDK #74755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c55d565
46574f1
d2ab85e
32e2ea0
5454b4f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,7 @@ | |
| AddArgBindingsToTIRunContext, | ||
| AddCallbackRunEndpoint, | ||
| AddDagRunNoteUpdateEndpoint, | ||
| AddExecutionTimeoutToTIRunContext, | ||
| AddFirstTaskRescheduleStartDateField, | ||
| AddLoopContext, | ||
| AddMultiTeamToTIRunContext, | ||
|
|
@@ -77,6 +78,7 @@ | |
| AddArgBindingsToTIRunContext, | ||
| AddCallbackRunEndpoint, | ||
| AddDagRunNoteUpdateEndpoint, | ||
| AddExecutionTimeoutToTIRunContext, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might need to decide which release this goes into before merging. 2026-10-30 already shipped in 3.4.0b1 and its published supervisor schema has no
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. Moving to 2027-02-28 is my preference, but on the supervisor-schema side it has a knock-on effect I'd like to check first. A new 2027-02-28 supervisor-schema version moves Is that acceptable, or would you rather keep 2026-10-30 and backport to v3-4-test before 3.4.0? I have the 2027-02-28 move ready locally and can push either way. The other three comments are addressed in 5454b4f, and the PR body now spells out the SIGTERM timing and the native Dag task coverage. Drafted-by: Claude Code (Opus 5.5) (no human review before posting) |
||
| AddLoopContext, | ||
| AddTerminalStateRetryReasonField, | ||
| AddMultiTeamToTIRunContext, | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the first lines here are the same lookup as
get_arg_bindings. Maybe a small helper that returns the stub task, so both can use it?