Repository navigation
[v3-4-test] Lazy-load the Code tab grammar from the Dag's stored language (#74643) - #74987
Merged
Merged
Conversation
…uage (#74643) Dag importers are pluggable, so core cannot list every language an importer may store in dag_code.language. Registering monaco's lazy grammar loaders lets the Code tab highlight any language monaco ships, fetching a grammar only when a Dag source first uses it. (cherry picked from commit 518f8d2) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
1 task done
vatsrahul1001
marked this pull request as ready for review
October 18, 2026 10:30
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 18, 2026 10:30
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…uage (#74643) (#74987) Dag importers are pluggable, so core cannot list every language an importer may store in dag_code.language. Registering monaco's lazy grammar loaders lets the Code tab highlight any language monaco ships, fetching a grammar only when a Dag source first uses it. (cherry picked from commit 518f8d2) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dag importers are pluggable, so core cannot list every language an importer may
store in dag_code.language. Registering monaco's lazy grammar loaders lets the
Code tab highlight any language monaco ships, fetching a grammar only when a
Dag source first uses it.
(cherry picked from commit 518f8d2)
Co-authored-by: Pierre Jeambrun pierrejbrun@gmail.com