Skip to content

Open the Dags menu from the Dags nav button instead of navigating - #75092

Merged
bbovenzi merged 1 commit into
apache:mainfrom
astronomer:dags-nav-menu
Oct 19, 2026
Merged

bbovenzi merged 1 commit into
apache:mainfrom
astronomer:dags-nav-menu

Conversation

@pierrejeambrun

@pierrejeambrun pierrejeambrun commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

#74745 put Dags, Dag Runs and Task Instances in a menu under the Dags nav button, but the button stayed a link. A click navigated to the Dags list and opened the menu over the new page at the same time, which reads as a flicker. It was also the only nav menu that behaved this way, since Browse, Admin and Security open their menu on click.

The Dags button is now a menu trigger like the others: hover or click opens the menu, and the Dags list is one of its entries. It is still highlighted on the Dags, Dag Runs and Task Instances pages. NavButton's matchPaths prop only existed for this button, so it is removed.

Clicking Dags while on the Pools page:

Before: navigates to the Dags list and opens the menu After: opens the menu and stays on the page
Before After

related: #74745


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5.5)

Generated-by: Claude Code (Opus 5.5) following the guidelines

The Dags button now heads a menu like Browse and Security, but it was
still a link. A click navigated to the Dags list and opened the menu
over the new page at the same time, which reads as a flicker. Treating
it as a menu trigger makes it behave like its siblings: hover or click
opens the menu, and the Dags list is one of its entries.
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 19, 2026
@pierrejeambrun
pierrejeambrun marked this pull request as ready for review October 19, 2026 11:56

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to figure out the balance of consistent UX vs making users click again. If this was confusing then let's go for the consistent ux approach

@bbovenzi bbovenzi added the backport-to-v3-4-test Backport to v3-4-test label Oct 19, 2026
@bbovenzi bbovenzi added this to the Airflow 3.4.0 milestone Oct 19, 2026
@bbovenzi
bbovenzi merged commit ab1acec into apache:main Oct 19, 2026
124 of 128 checks passed
@bbovenzi
bbovenzi deleted the dags-nav-menu branch October 19, 2026 14:49
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 19, 2026
…vigating (apache#75092)

The Dags button now heads a menu like Browse and Security, but it was
still a link. A click navigated to the Dags list and opened the menu
over the new page at the same time, which reads as a flicker. Treating
it as a menu trigger makes it behave like its siblings: hover or click
opens the menu, and the Dags list is one of its entries.
(cherry picked from commit ab1acec)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 19, 2026
…vigating (apache#75092)

The Dags button now heads a menu like Browse and Security, but it was
still a link. A click navigated to the Dags list and opened the menu
over the new page at the same time, which reads as a flicker. Treating
it as a menu trigger makes it behave like its siblings: hover or click
opens the menu, and the Dags list is one of its entries.
(cherry picked from commit ab1acec)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
bbovenzi pushed a commit that referenced this pull request Oct 19, 2026
…vigating (#75092) (#75109)

The Dags button now heads a menu like Browse and Security, but it was
still a link. A click navigated to the Dags list and opened the menu
over the new page at the same time, which reads as a flicker. Treating
it as a menu trigger makes it behave like its siblings: hover or click
opens the menu, and the Dags list is one of its entries.
(cherry picked from commit ab1acec)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 20, 2026
…vigating (#75092) (#75109)

The Dags button now heads a menu like Browse and Security, but it was
still a link. A click navigated to the Dags list and opened the menu
over the new page at the same time, which reads as a flicker. Treating
it as a menu trigger makes it behave like its siblings: hover or click
opens the menu, and the Dags list is one of its entries.
(cherry picked from commit ab1acec)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants