Repository navigation
[v3-4-test] Keep DAG folder selection distinct across bundle names (#75080) - #75146
Merged
Merged
Conversation
1 task done
vatsrahul1001
marked this pull request as ready for review
October 20, 2026 03:12
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 20, 2026 03:12
The cherry-picked colons test uses `await waitFor(...)`, but v3-4-test's base test file never imported waitFor (main's did), so the React UI test failed with "ReferenceError: waitFor is not defined". Add it to the @testing-library/react import, matching main.
vatsrahul1001
approved these changes
Oct 20, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
added a commit
that referenced
this pull request
Oct 20, 2026
…75080) (#75146) * [v3-4-test] Keep DAG folder selection distinct across bundle names (#75080) (cherry picked from commit c581c18) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com> * Import waitFor in DagFolderTree test The cherry-picked colons test uses `await waitFor(...)`, but v3-4-test's base test file never imported waitFor (main's did), so the React UI test failed with "ReferenceError: waitFor is not defined". Add it to the @testing-library/react import, matching main. --------- Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c581c18)
Co-authored-by: Himanshu Chawla himanshuchawla0807@gmail.com
Co-authored-by: Himanshu Chawla 241715894+himanshuchawla0807-gif@users.noreply.github.com