Repository navigation
TS SDK: Reject blank edge labels and label task edges into groups - #75190
Merged
Merged
Conversation
1 task done
FrankYang0529
marked this pull request as ready for review
October 20, 2026 10:22
jason810496
self-requested a review
October 21, 2026 05:49
jason810496
reviewed
Oct 22, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for filling up the gap, the PR LGTM overall.
Here're some findings by the agent review, thanks.
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
ts-sdk-label-syntax
branch
from
October 22, 2026 03:04
a584cc3 to
f4c4c81
Compare
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change label form from
label(node, text)toLabel.of(text).On(node)as Java SDK's edge labels (#74523).onrequires at least one task or task group at compile time.onputs the same label on the edge to or from each node passed to it, as Python'sload >> Label("forks") >> [report_empty, notify]does. When a labelled value is labelled again, the outer label wins.Was generative AI tooling used to co-author this PR?