Repository navigation
Reveal selected Dag folders when names contain pipes - #75196
Merged
bbovenzi merged 2 commits intoOct 21, 2026
Merged
Conversation
Distinct bundle and folder selections can share a delimiter-joined key, leaving the selected folder hidden during navigation.
himanshuchawla0807-gif
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 20, 2026 08:29
bbovenzi
approved these changes
Oct 20, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 22, 2026
…che#75196) Distinct bundle and folder selections can share a delimiter-joined key, leaving the selected folder hidden during navigation. (cherry picked from commit 57aedbf) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 23, 2026
) (#75319) Distinct bundle and folder selections can share a delimiter-joined key, leaving the selected folder hidden during navigation. (cherry picked from commit 57aedbf) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching from bundle
a|b, foldercto bundlea, folderb|cleaves the newly selected folder hidden because both selections produce the same delimiter-joined change key. Serialize the selection fields as a tuple so the new bundle and selected folder expand correctly.The regression checks selection and visibility after rerendering. It fails with the previous key construction and passes with this fix. Existing manual collapse/expansion behavior remains covered.
Validation:
The initial shared-distribution and CI-image failures were caused by duplicate
pyvespaentries in the upstreamuv.lock, repaired upstream by #75200. Merged the repaired base into this branch without rewriting history; the 31 folder tests and regular/manual checks still pass. The UI source and dependency lockfile are unchanged by that base update.Before/after below use the actual
DagFolderTreecomponent with local fixture folders, rather than a deployed Airflow API server.Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines.
Drafted-by: OpenAI Codex (no human review before posting)