Repository navigation
Reject non-object JSON files when importing variables - #75384
Merged
vatsrahul1001 merged 1 commit intoOct 29, 2026
Merged
vatsrahul1001 merged 1 commit into
vatsrahul1001 merged 1 commit into
Conversation
Array and primitive documents cannot represent a mapping of variable names to values and can otherwise enable unintended imports.
himanshuchawla0807-gif
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 22, 2026 08:20
bbovenzi
approved these changes
Oct 27, 2026
bbovenzi
enabled auto-merge (squash)
October 27, 2026 17:39
vatsrahul1001
disabled auto-merge
October 29, 2026 09:44
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 29, 2026
…5384) Array and primitive documents cannot represent a mapping of variable names to values and can otherwise enable unintended imports. (cherry picked from commit eafb6ed) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 30, 2026
…5384) (#75950) Array and primitive documents cannot represent a mapping of variable names to values and can otherwise enable unintended imports. (cherry picked from commit eafb6ed) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 30, 2026
…5384) (#75950) Array and primitive documents cannot represent a mapping of variable names to values and can otherwise enable unintended imports. (cherry picked from commit eafb6ed) Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com> Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Variables upload form currently accepts any valid JSON value as a dictionary. For example,
["example"]enables Import and is converted byObject.entriesinto a variable named0; a JSON string is split into character-indexed variables. Numbers and booleans also enable an empty import, whilenullsilently leaves the button disabled.Require a non-null, non-array JSON object before enabling Import. Other document shapes now use the existing translated error, which already explains the expected key/value format. Nested values inside a valid object are preserved.
Validation:
breeze verify --jsonselects both UI suites, which were run. Manual hooks unrelated to these files correctly skip.Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
No prior human review is claimed.