Repository navigation
[v3-4-test] Read a team's running task logs through the team's executor (#75255) - #75408
Merged
Merged
Conversation
1 task done
boring-cyborg
Bot
added
area:Executors-core
…or (#75255) In multi-team mode, the API server reads a running task's logs through the global default executor, or looks up the task's named executor in the global scope only. A team's executor has its own config, such as the cluster its KubernetesExecutor pods run on, so a team task's live logs came from the wrong executor: nothing from a global LocalExecutor, or "Cannot find pod" from a global KubernetesExecutor on another cluster. Resolve the executor the same way the scheduler does: the team's executor, and a global one if the team doesn't have it. (cherry picked from commit 1e3a232) Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com>
github-actions
Bot
force-pushed
the
backport-1e3a232-v3-4-test
branch
from
October 22, 2026 13:42
4e95d31 to
5db0da9
Compare
vincbeck
marked this pull request as ready for review
October 22, 2026 13:45
vincbeck
requested review from
XD-DENG,
ashb,
dheerajturaga,
hussein-awala,
o-nikolas and
pierrejeambrun
as code owners
October 22, 2026 13:45
vincbeck
approved these changes
Oct 22, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-team mode, the API server reads a running task's logs through the
global default executor, or looks up the task's named executor in the
global scope only. A team's executor has its own config, such as the
cluster its KubernetesExecutor pods run on, so a team task's live logs came
from the wrong executor: nothing from a global LocalExecutor, or "Cannot
find pod" from a global KubernetesExecutor on another cluster.
Resolve the executor the same way the scheduler does: the team's executor,
and a global one if the team doesn't have it.
(cherry picked from commit 1e3a232)
Co-authored-by: Sean Ghaeli 58916776+seanghaeli@users.noreply.github.com