Repository navigation
UI: Fix visual and console-error bugs in Dag list and details - #75418
Merged
vatsrahul1001 merged 2 commits intoOct 25, 2026
Merged
Conversation
These are pre-existing bugs, all found while testing an unrelated change and all in the same corner of the UI, so they travel together rather than as a handful of one-line pull requests. Several survived review because nothing asserted on them: the Gantt axis only collided its React keys on runs of roughly twenty seconds or less, the warnings marker only stretched on a Dag that actually had a warning, and the HITL tab lookup only logged its 404 on a task that was not human-in-the-loop. Each now has a test that fails without its fix. The Dag status markers are consolidated because apache#74516 moved every other Dag status onto the shared StatusChip and left this one behind. That left two markers that looked identical, sat in different containers, and meant different things, with no single place to see everything wrong with a Dag. Co-Authored-By: Claude <noreply@anthropic.com>
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 22, 2026 16:10
kaxil
approved these changes
Oct 22, 2026
kaxil
reviewed
Oct 22, 2026
The merged status chip was introducing the same class of console error the rest of the change removes. Rich detail was rendered inside a paragraph, which cannot hold the blocks the import-error view brings, so the browser closed the paragraph early and the file row inherited an error colour and type scale meant only for the traceback. Tests now fail on React's markup warnings instead of letting them scroll past in CI output, which is what let this through: the test that opens that very modal was passing while logging two nesting errors. Three assertions could not fail as written. One searched for a nested button only inside the inner button, so restoring the old wrapper would have gone unnoticed; one asked for a chip named after a deactivation that the import-error branch can never produce; one opened the modal for a failed request without checking the failure reached it. Warning types reached the heading as the backend's own lowercase enum values, which would have shown untranslated English in every locale, so they are translated now rather than passed through. The chip and its modal each walked the severity order themselves and would have disagreed the moment one changed. Co-Authored-By: Claude <noreply@anthropic.com>
bbovenzi
requested review from
BasPH,
Lee-W,
ashb,
bugraoz93,
henry3260,
hussein-awala,
jason810496,
jscheffl,
mobuchowski,
potiuk,
romsharon98,
sekikn,
shahar1,
uranusjr and
vincbeck
as code owners
October 23, 2026 14:36
vatsrahul1001
enabled auto-merge (squash)
October 24, 2026 17:16
vatsrahul1001
disabled auto-merge
October 25, 2026 05:29
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 25, 2026
…ails (apache#75418) * UI: Fix visual and console-error bugs in Dag list and details These are pre-existing bugs, all found while testing an unrelated change and all in the same corner of the UI, so they travel together rather than as a handful of one-line pull requests. Several survived review because nothing asserted on them: the Gantt axis only collided its React keys on runs of roughly twenty seconds or less, the warnings marker only stretched on a Dag that actually had a warning, and the HITL tab lookup only logged its 404 on a task that was not human-in-the-loop. Each now has a test that fails without its fix. The Dag status markers are consolidated because apache#74516 moved every other Dag status onto the shared StatusChip and left this one behind. That left two markers that looked identical, sat in different containers, and meant different things, with no single place to see everything wrong with a Dag. Co-Authored-By: Claude <noreply@anthropic.com> * UI: Address review on the Dag status chip and warning translations The merged status chip was introducing the same class of console error the rest of the change removes. Rich detail was rendered inside a paragraph, which cannot hold the blocks the import-error view brings, so the browser closed the paragraph early and the file row inherited an error colour and type scale meant only for the traceback. Tests now fail on React's markup warnings instead of letting them scroll past in CI output, which is what let this through: the test that opens that very modal was passing while logging two nesting errors. Three assertions could not fail as written. One searched for a nested button only inside the inner button, so restoring the old wrapper would have gone unnoticed; one asked for a chip named after a deactivation that the import-error branch can never produce; one opened the modal for a failed request without checking the failure reached it. Warning types reached the heading as the backend's own lowercase enum values, which would have shown untranslated English in every locale, so they are translated now rather than passed through. The chip and its modal each walked the severity order themselves and would have disagreed the moment one changed. Co-Authored-By: Claude <noreply@anthropic.com> --------- (cherry picked from commit da4fafc) Co-authored-by: Brent Bovenzi <brent@astronomer.io> Co-authored-by: Claude <noreply@anthropic.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 25, 2026
…ails (#75418) (#75593) * UI: Fix visual and console-error bugs in Dag list and details These are pre-existing bugs, all found while testing an unrelated change and all in the same corner of the UI, so they travel together rather than as a handful of one-line pull requests. Several survived review because nothing asserted on them: the Gantt axis only collided its React keys on runs of roughly twenty seconds or less, the warnings marker only stretched on a Dag that actually had a warning, and the HITL tab lookup only logged its 404 on a task that was not human-in-the-loop. Each now has a test that fails without its fix. The Dag status markers are consolidated because #74516 moved every other Dag status onto the shared StatusChip and left this one behind. That left two markers that looked identical, sat in different containers, and meant different things, with no single place to see everything wrong with a Dag. * UI: Address review on the Dag status chip and warning translations The merged status chip was introducing the same class of console error the rest of the change removes. Rich detail was rendered inside a paragraph, which cannot hold the blocks the import-error view brings, so the browser closed the paragraph early and the file row inherited an error colour and type scale meant only for the traceback. Tests now fail on React's markup warnings instead of letting them scroll past in CI output, which is what let this through: the test that opens that very modal was passing while logging two nesting errors. Three assertions could not fail as written. One searched for a nested button only inside the inner button, so restoring the old wrapper would have gone unnoticed; one asked for a chip named after a deactivation that the import-error branch can never produce; one opened the modal for a failed request without checking the failure reached it. Warning types reached the heading as the backend's own lowercase enum values, which would have shown untranslated English in every locale, so they are translated now rather than passed through. The chip and its modal each walked the severity order themselves and would have disagreed the moment one changed. --------- (cherry picked from commit da4fafc) Co-authored-by: Brent Bovenzi <brent@astronomer.io> Co-authored-by: Claude <noreply@anthropic.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bunch of various UI bugs.
dagWarnings.errorAndWarningpassing the wrong variable name, so "1 Error and N Warnings" has been rendering with its second half missing in every localenon-existent pool,runtime varying value), untranslated in every language. They are mapped to i18n keys now and translated into all 20 locales — those translations are machine-generated and anchored on each locale's existing glossary, so a locale owner's eye on them would be welcomeWarning banner before:
After:
Dag card before:
After:
Filter margin before:
After:
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines