Repository navigation
[v3-4-test] Run team tasks on the team executor when named by class or path (#75362) - #75436
Merged
Merged
Conversation
…r path (#75362) With multi-team enabled, a team task that names its executor by class name or module path (e.g. executor="CeleryExecutor") is documented to run on its team's executor of that class. Only the global alias should reach the global executor ("Aliasing Executors Across Teams" in the multi-team docs). The scheduler took the first matching executor instead, and global executors are always listed before team ones. So these tasks silently ran on the shared global executor, outside the team boundary, and anything resolving executors the documented way (such as reading live task logs) looked in the wrong place. (cherry picked from commit 0abd161) Co-authored-by: Niko Oliveira <onikolas@apache.org>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With multi-team enabled, a team task that names its executor by class
name or module path (e.g. executor="CeleryExecutor") is documented to
run on its team's executor of that class. Only the global alias should
reach the global executor ("Aliasing Executors Across Teams" in the
multi-team docs).
The scheduler took the first matching executor instead, and global
executors are always listed before team ones. So these tasks silently
ran on the shared global executor, outside the team boundary, and
anything resolving executors the documented way (such as reading live
task logs) looked in the wrong place.
(cherry picked from commit 0abd161)
Co-authored-by: Niko Oliveira onikolas@apache.org