Repository navigation
[v3-4-test] Redact secrets written through RedactedIO.writelines() (#72063) - #75463
Merged
Merged
Conversation
…72063) RedactedIO exists so that output produced by user code is masked before it reaches stdout, and its docstring says "Writes to stdout will be redacted". write() applied redact(); writelines() forwarded straight to the target, so a secret written that way was printed verbatim. The one call site is task_test() in cli/commands/task_command.py, so this is reachable from `airflow tasks test`, which deliberately routes task output up to the console handler for local debugging. Non-string elements now stringify rather than raising TypeError, matching what write() already does. (cherry picked from commit 3d5c533) Co-authored-by: Mahathir Mohammad Shuvo <48558774+MahathirMohammadShuvo@users.noreply.github.com>
1 task done
vatsrahul1001
marked this pull request as ready for review
October 23, 2026 12:45
vatsrahul1001
requested review from
amoghrajesh,
ashb and
potiuk
as code owners
October 23, 2026 12:45
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedactedIO exists so that output produced by user code is masked before it
reaches stdout, and its docstring says "Writes to stdout will be redacted".
write() applied redact(); writelines() forwarded straight to the target, so a
secret written that way was printed verbatim.
The one call site is task_test() in cli/commands/task_command.py, so this is
reachable from
airflow tasks test, which deliberately routes task output upto the console handler for local debugging.
Non-string elements now stringify rather than raising TypeError, matching what
write() already does.
(cherry picked from commit 3d5c533)
Co-authored-by: Mahathir Mohammad Shuvo 48558774+MahathirMohammadShuvo@users.noreply.github.com