Repository navigation
[v3-4-test] Go SDK: fail a task whose return-value XCom push fails (#75443) - #75476
Merged
Merged
Conversation
…75443) * Go SDK: fail a task whose return-value XCom push fails, fix the Label doc A failed return-value push was logged and the task was left successful, so the downstream tasks that read it failed later with XComNotFound. Fail the task instead, and stop pushing a result the task never produced when its function already returned an error, as the branch path does. The guide's labelled-edge example did not compile: Label takes only the text, and On names the tasks its edges reach. * Go SDK: address review on the return-value XCom push Push the task instance from the runtime context as is, share its lookup with startBranch, and cover the failed push on the branch path. Merge the copied test helper into runTask. * Go SDK: test that a task pushes no nil-pointer return value Only the branch path covered this check, and a nil pointer that slipped past it would be pushed as null now that a push can fail the task. --------- (cherry picked from commit 1a50a18) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
1 task done
jason810496
marked this pull request as ready for review
October 23, 2026 13:47
jason810496
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 23, 2026 13:47
jason810496
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed return-value push was logged and the task was left successful, so the
downstream tasks that read it failed later with XComNotFound. Fail the task
instead, and stop pushing a result the task never produced when its function
already returned an error, as the branch path does.
The guide's labelled-edge example did not compile: Label takes only the text,
and On names the tasks its edges reach.
Push the task instance from the runtime context as is, share its lookup
with startBranch, and cover the failed push on the branch path. Merge the
copied test helper into runTask.
Only the branch path covered this check, and a nil pointer that slipped
past it would be pushed as null now that a push can fail the task.
(cherry picked from commit 1a50a18)
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com