Repository navigation
[v3-4-test] Show the filtered task count in the Dag Tasks tab heading (#75448) - #75490
Merged
Merged
Conversation
1 task done
vatsrahul1001
marked this pull request as ready for review
October 24, 2026 10:41
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 24, 2026 10:41
vatsrahul1001
enabled auto-merge (squash)
October 24, 2026 13:47
…#75448) The Tasks tab filters the task list client-side (operator, trigger rule, retries, mapped, name search) but passed the API's total_entries to the DataTable heading, so the heading kept reporting the unfiltered count ("12 Tasks") even when a search narrowed the list to a single task. Pass the filtered list's length instead, as Configs.tsx already does for its client-built list, and assert the count in the existing filter tests. (cherry picked from commit 99bdeab) Co-authored-by: 김난희 <nanhee.kim@ishopcare.co.kr> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
vatsrahul1001
force-pushed
the
backport-99bdeab-v3-4-test
branch
from
October 24, 2026 13:52
4abf7bb to
b83b356
Compare
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tasks tab filters the task list client-side (operator, trigger rule,
retries, mapped, name search) but passed the API's total_entries to the
DataTable heading, so the heading kept reporting the unfiltered count
("12 Tasks") even when a search narrowed the list to a single task.
Pass the filtered list's length instead, as Configs.tsx already does for
its client-built list, and assert the count in the existing filter tests.
(cherry picked from commit 99bdeab)
Co-authored-by: 김난희 nanhee.kim@ishopcare.co.kr
Co-authored-by: Claude Fable 5.1 noreply@anthropic.com