Repository navigation
[v3-4-test] Decide min_one_success trigger rules per index in mapped task groups (#75417) - #75511
Merged
Merged
Conversation
1 task done
shahar1
marked this pull request as ready for review
October 23, 2026 17:02
shahar1
approved these changes
Oct 23, 2026
vatsrahul1001
enabled auto-merge (squash)
October 24, 2026 13:51
vatsrahul1001
force-pushed
the
backport-b43705c-v3-4-test
branch
from
October 24, 2026 13:51
08e23a3 to
4f6d87f
Compare
…task groups (#75417) With an upstream outside the group, the placeholder of an all_done_min_one_success task decided the whole task from that upstream alone. A none_failed_min_one_success task failed every index when one upstream index failed. For both rules, the placeholder now hands the decision to the expanded instances once an in-group upstream has expanded. Each index is then judged by its own upstreams. (cherry picked from commit b43705c) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
vatsrahul1001
force-pushed
the
backport-b43705c-v3-4-test
branch
from
October 26, 2026 04:02
4f6d87f to
553e0fa
Compare
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an upstream outside the group, the placeholder of an
all_done_min_one_success task decided the whole task from that upstream
alone. A none_failed_min_one_success task failed every index when one
upstream index failed.
For both rules, the placeholder now hands the decision to the expanded
instances once an in-group upstream has expanded. Each index is then
judged by its own upstreams.
(cherry picked from commit b43705c)
Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com