Repository navigation
Load Common AI plugin tabs when the browser reaches Airflow on another origin - #75522
Merged
Merged
Conversation
…r origin get_bundle_url copied the scheme and host of [api] base_url into the plugin bundle URL. When the browser reached Airflow on a different origin, such as through a local proxy, the AI Model and HITL Review tabs imported their bundle cross-origin and rendered empty. Return only the path, which the host UI resolves against the page it was loaded from.
Member
Author
|
cc @hussein-awala Need to get this to in Common AI provider 1.1.0rc2 |
pankajkoti
approved these changes
Oct 23, 2026
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI Model and HITL Review tabs render empty when the browser reaches Airflow on a different origin than
[api] base_urlnames, for example through a local development proxy whilebase_urlishttp://localhost:8080.get_bundle_urlcopied the scheme and host ofbase_urlinto each plugin'sbundle_url, so the browser imported the bundle from that other origin and the import failed: a CORS error when something answers there, connection refused when nothing does.get_bundle_urlnow returns only the path, as the Edge3 plugin already does. The core UI likewise builds its own URLs from the request path, not frombase_url.The absolute URL is no longer needed for Vite dev mode. It was added so the bundle loaded from core's Vite dev server, where
import()resolved relative to the dev server's origin. Since #66618 (Airflow 3.3.0) the host resolvesbundle_urlagainstdocument.baseURI(ReactPlugin.tsx), so a path loads there too. Vite dev mode only runs frommain, and a built UI on any version resolves a path against the page's origin, which the Edge3 plugin relies on.Before and after, with
base_url = http://localhost:8080and the UI opened on another port:{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.