Skip to content

Keep Breeze unit tests independent of the CI repository - #75587

Merged
shahar1 merged 1 commit into
apache:mainfrom
potiuk:breeze-tests-ignore-github-repository
Oct 25, 2026
Merged

shahar1 merged 1 commit into
apache:mainfrom
potiuk:breeze-tests-ignore-github-repository

Conversation

@potiuk

@potiuk potiuk commented Oct 24, 2026

Copy link
Copy Markdown
Member

Breeze commands read --github-repository from GITHUB_REPOSITORY. Unit tests that rely on its apache/airflow default pass on project CI only because the variable happens to be apache/airflow there. In a contributor's fork it is <user>/airflow, so five Breeze unit tests fail and the fork's CI passed check goes red on every pull request (seen in the fork run for #75586: https://github.com/higrys/airflow/actions/runs/40135803573). Fork CI (AIP-120) relies on that run being green.

An autouse fixture now unsets GITHUB_REPOSITORY for every Breeze test. The two tests that need a repository pass it in their own environment dicts.

Checked locally with GITHUB_REPOSITORY=higrys/airflow set: without the fixture the same five tests fail; with it the Breeze test suite passes (1743 passed, 7 skipped). Fast prek hooks pass.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines


🤖 Generated with Claude Code

Breeze commands read --github-repository from GITHUB_REPOSITORY, so the
unit tests that rely on its apache/airflow default fail when CI runs in a
contributor's fork.

Generated-by: Claude Opus 5
@shahar1
shahar1 merged commit 8e3a911 into apache:main Oct 25, 2026
59 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

vatsrahul1001 pushed a commit that referenced this pull request Oct 25, 2026
…75587) (#75591)

Breeze commands read --github-repository from GITHUB_REPOSITORY, so the
unit tests that rely on its apache/airflow default fail when CI runs in a
contributor's fork.
(cherry picked from commit 8e3a911)


Generated-by: Claude Opus 5

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk potiuk added this to the Airflow 3.4.0 milestone Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants