Repository navigation
[v3-4-test] Return 5xx on database deadlock when updating task state (#75368) - #75652
Merged
Merged
Conversation
…75368) A deadlock is transient and the task would succeed on a retry, but the catch-all around the state update marked the task instance FAILED, which is permanent. The Task SDK client already retries 5xx responses from the Execution API, so letting the deadlock surface as a 500 gives the worker that retry. Only deadlocks are treated this way. Recognising other lock errors would change how existing callers of is_lock_not_available_error behave. (cherry picked from commit 840d3a4) Co-authored-by: Wei Lee <weilee@apache.org>
1 task done
Lee-W
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deadlock is transient and the task would succeed on a retry, but the
catch-all around the state update marked the task instance FAILED, which
is permanent. The Task SDK client already retries 5xx responses from the
Execution API, so letting the deadlock surface as a 500 gives the worker
that retry.
Only deadlocks are treated this way. Recognising other lock errors would
change how existing callers of is_lock_not_available_error behave.
(cherry picked from commit 840d3a4)
Co-authored-by: Wei Lee weilee@apache.org